netdev - Re: [PATCH net-next v10 01/22] net: make page_pool_ref

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250115184850.4d30e408@kernel.org>
Date: Wed, 15 Jan 2025 18:48:50 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Pavel Begunkov <asml.silence@...il.com>
Cc: David Wei <dw@...idwei.uk>, io-uring@...r.kernel.org,
 netdev@...r.kernel.org, Jens Axboe <axboe@...nel.dk>, Paolo Abeni
 <pabeni@...hat.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Jesper Dangaard Brouer <hawk@...nel.org>, David
 Ahern <dsahern@...nel.org>, Mina Almasry <almasrymina@...gle.com>,
 Stanislav Fomichev <stfomichev@...il.com>, Joe Damato <jdamato@...tly.com>,
 Pedro Tammela <pctammela@...atatu.com>
Subject: Re: [PATCH net-next v10 01/22] net: make page_pool_ref_netmem work
 with net iovs

On Thu, 16 Jan 2025 02:12:06 +0000 Pavel Begunkov wrote:
> On 1/16/25 00:30, Jakub Kicinski wrote:
> > On Wed,  8 Jan 2025 14:06:22 -0800 David Wei wrote:  
> >> From: Pavel Begunkov <asml.silence@...il.com>
> >>
> >> page_pool_ref_netmem() should work with either netmem representation, but
> >> currently it casts to a page with netmem_to_page(), which will fail with
> >> net iovs. Use netmem_get_pp_ref_count_ref() instead.  
> > 
> > This is a fix, right? If we try to coalesce a cloned netmem skb
> > we'll crash.  
> 
> True, I missed it it's actually used.

I'll add:

Fixes: 8ab79ed50cf1 ("page_pool: devmem support")

and we'll send it to Linus tomorrow. Hope that's okay.