netdev - Re: [PATCH net] net: ethernet: ti: am65-cpsw: fix freeing IRQ in am65_cpsw_nuss_remove_tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <y6hpbuck3fvxy3z6iajjgjkgmwy3773slen4j2we5pumsl77jp@oy5gp2ppfwfr>
Date: Thu, 16 Jan 2025 10:39:02 +0530
From: Siddharth Vadapalli <s-vadapalli@...com>
To: Roger Quadros <rogerq@...nel.org>
CC: Siddharth Vadapalli <s-vadapalli@...com>,
        Andrew Lunn
	<andrew+netdev@...n.ch>,
        "David S. Miller" <davem@...emloft.net>,
        "Eric
 Dumazet" <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>,
        Grygorii Strashko <grygorii.strashko@...com>, <srk@...com>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net] net: ethernet: ti: am65-cpsw: fix freeing IRQ in
 am65_cpsw_nuss_remove_tx_chns()

On Wed, Jan 15, 2025 at 05:49:44PM +0200, Roger Quadros wrote:
> Hi Siddharth,
> 
> On 15/01/2025 12:38, Siddharth Vadapalli wrote:

[...]

> > Only when the user re-invokes am65_cpsw_nuss_update_tx_rx_chns(),
> > the cleanup will be performed. This might have to be fixed in the
> > following manner:
> > 
> > @@ -3416,10 +3416,17 @@ int am65_cpsw_nuss_update_tx_rx_chns(struct am65_cpsw_common *common,
> >         common->tx_ch_num = num_tx;
> >         common->rx_ch_num_flows = num_rx;
> >         ret = am65_cpsw_nuss_init_tx_chns(common);
> > -       if (ret)
> > +       if (ret) {
> > +               devm_remove_action(dev, am65_cpsw_nuss_free_tx_chns, common);
> > +               am65_cpsw_nuss_free_tx_chns(common);
> >                 return ret;
> > +       }
> > 
> >         ret = am65_cpsw_nuss_init_rx_chns(common);
> > +       if (ret) {
> > +               devm_remove_action(dev, am65_cpsw_nuss_free_rx_chns, common);
> > +               am65_cpsw_nuss_free_rx_chns(common);
> > +       }
> > 
> >         return ret;
> >  }
> > 
> >  Please let me know what you think.
> 
> I've already implemented a cleanup series to get rid of devm_add/remove_action,
> cleanup probe error path and streamline TX and RQ queue init/cleanup.
> I'll send out the series soon as soon as I finish some tests.

Sure, thank you.

Regards,
Siddharth.