netdev - RE: [Intel-wired-lan] [PATCH iwl-net v1] ice: remove invalid parameter of equalizer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <IA1PR11MB6241A6E9185367C1C4DB0A218B1A2@IA1PR11MB6241.namprd11.prod.outlook.com>
Date: Thu, 16 Jan 2025 05:49:04 +0000
From: "Rinitha, SX" <sx.rinitha@...el.com>
To: "Polchlopek, Mateusz" <mateusz.polchlopek@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Polchlopek, Mateusz"
	<mateusz.polchlopek@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH iwl-net v1] ice: remove invalid
 parameter of equalizer

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Mateusz Polchlopek
> Sent: 31 December 2024 15:21
> To: intel-wired-lan@...ts.osuosl.org
> Cc: netdev@...r.kernel.org; Polchlopek, Mateusz <mateusz.polchlopek@...el.com>
> Subject: [Intel-wired-lan] [PATCH iwl-net v1] ice: remove invalid parameter of equalizer
>
> It occurred that in the commit 70838938e89c ("ice: Implement driver functionality to dump serdes equalizer values") the invalid DRATE parameter for reading has been added. The output of the command:
>
> $ ethtool -d <ethX>
>
> returns the garbage value in the place where DRATE value should be stored.
>
> Remove mentioned parameter to prevent return of corrupted data to userspace.
>
> Fixes: 70838938e89c ("ice: Implement driver functionality to dump serdes equalizer values")
> Signed-off-by: Mateusz Polchlopek <mateusz.polchlopek@...el.com>
> ---
> drivers/net/ethernet/intel/ice/ice_adminq_cmd.h | 1 -
> drivers/net/ethernet/intel/ice/ice_ethtool.c    | 1 -
> drivers/net/ethernet/intel/ice/ice_ethtool.h    | 1 -
> 3 files changed, 3 deletions(-)
>

Tested-by: Rinitha S <sx.rinitha@...el.com> (A Contingent worker at Intel)