netdev - Re: [PATCH v3 01/14] net-next/yunsilicon: Add xsc driver basic framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <9616014e-49ed-44c0-81f2-526cefac59ab@yunsilicon.com>
Date: Thu, 16 Jan 2025 15:03:10 +0800
From: "tianx" <tianx@...silicon.com>
To: "Simon Horman" <horms@...nel.org>
Cc: <netdev@...r.kernel.org>, <leon@...nel.org>, <andrew+netdev@...n.ch>, 
	<kuba@...nel.org>, <pabeni@...hat.com>, <edumazet@...gle.com>, 
	<davem@...emloft.net>, <jeff.johnson@....qualcomm.com>, 
	<przemyslaw.kitszel@...el.com>, <weihg@...silicon.com>, 
	<wanry@...silicon.com>
Subject: Re: [PATCH v3 01/14] net-next/yunsilicon: Add xsc driver basic framework

On 2025/1/15 23:54, Simon Horman wrote:
> On Wed, Jan 15, 2025 at 06:22:44PM +0800, Xin Tian wrote:
>> Add yunsilicon xsc driver basic framework, including xsc_pci driver
>> and xsc_eth driver
>>
>> Co-developed-by: Honggang Wei <weihg@...silicon.com>
>> Signed-off-by: Honggang Wei <weihg@...silicon.com>
>> Co-developed-by: Lei Yan <jacky@...silicon.com>
>> Signed-off-by: Lei Yan <jacky@...silicon.com>
>> Signed-off-by: Xin Tian <tianx@...silicon.com>
> ...
>
>> diff --git a/drivers/net/ethernet/yunsilicon/xsc/common/xsc_core.h b/drivers/net/ethernet/yunsilicon/xsc/common/xsc_core.h
> ...
>
>> +struct xsc_dev_resource {
>> +	struct mutex alloc_mutex;	/* protect buffer alocation according to numa node */
> nit: allocation
OK, will fix
>
> ...
>
>> diff --git a/drivers/net/ethernet/yunsilicon/xsc/pci/main.c b/drivers/net/ethernet/yunsilicon/xsc/pci/main.c
> ...
>
>> +static int xsc_pci_init(struct xsc_core_device *xdev, const struct pci_device_id *id)
>> +{
>> +	struct pci_dev *pdev = xdev->pdev;
>> +	void __iomem *bar_base;
>> +	int bar_num = 0;
>> +	int err;
>> +
>> +	xdev->numa_node = dev_to_node(&pdev->dev);
>> +
>> +	err = xsc_pci_enable_device(xdev);
>> +	if (err) {
>> +		pci_err(pdev, "failed to enable PCI device: err=%d\n", err);
>> +		goto err_ret;
>> +	}
>> +
>> +	err = pci_request_region(pdev, bar_num, KBUILD_MODNAME);
>> +	if (err) {
>> +		pci_err(pdev, "failed to request %s pci_region=%d: err=%d\n",
>> +			KBUILD_MODNAME, bar_num, err);
>> +		goto err_disable;
>> +	}
>> +
>> +	pci_set_master(pdev);
>> +
>> +	err = set_dma_caps(pdev);
>> +	if (err) {
>> +		pci_err(pdev, "failed to set DMA capabilities mask: err=%d\n", err);
>> +		goto err_clr_master;
>> +	}
>> +
>> +	bar_base = pci_ioremap_bar(pdev, bar_num);
>> +	if (!bar_base) {
>> +		pci_err(pdev, "failed to ioremap %s bar%d\n", KBUILD_MODNAME, bar_num);
> Should err, which will be the return value of the function,
> be set to a negative error value here? As is, the function will
> return 0.
Thank you for pointing this out, Simon. I'll correct it in next version.
>> +		goto err_clr_master;
>> +	}
>> +
>> +	err = pci_save_state(pdev);
>> +	if (err) {
>> +		pci_err(pdev, "pci_save_state failed: err=%d\n", err);
>> +		goto err_io_unmap;
>> +	}
>> +
>> +	xdev->bar_num = bar_num;
>> +	xdev->bar = bar_base;
>> +
>> +	return 0;
>> +
>> +err_io_unmap:
>> +	pci_iounmap(pdev, bar_base);
>> +err_clr_master:
>> +	pci_clear_master(pdev);
>> +	pci_release_region(pdev, bar_num);
>> +err_disable:
>> +	xsc_pci_disable_device(xdev);
>> +err_ret:
>> +	return err;
>> +}
> ...