netdev - Re: [PATCH net-next v18 09/25] ovpn: implement packet processing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1bbbde25-ef86-4890-9984-bd2f502e9e9e@openvpn.net>
Date: Fri, 17 Jan 2025 13:28:33 +0100
From: Antonio Quartulli <antonio@...nvpn.net>
To: Sabrina Dubroca <sd@...asysnail.net>
Cc: netdev@...r.kernel.org, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Donald Hunter <donald.hunter@...il.com>, Shuah Khan <shuah@...nel.org>,
 ryazanov.s.a@...il.com, Andrew Lunn <andrew+netdev@...n.ch>,
 Simon Horman <horms@...nel.org>, linux-kernel@...r.kernel.org,
 linux-kselftest@...r.kernel.org, Xiao Liang <shaw.leon@...il.com>
Subject: Re: [PATCH net-next v18 09/25] ovpn: implement packet processing

On 17/01/2025 13:16, Sabrina Dubroca wrote:
> 2025-01-13, 10:31:28 +0100, Antonio Quartulli wrote:
>>   static bool ovpn_encrypt_one(struct ovpn_peer *peer, struct sk_buff *skb)
>>   {
>> -	ovpn_skb_cb(skb)->peer = peer;
>> +	struct ovpn_crypto_key_slot *ks;
>> +
>> +	if (unlikely(skb->ip_summed == CHECKSUM_PARTIAL &&
>> +		     skb_checksum_help(skb))) {
>> +		net_warn_ratelimited("%s: cannot compute checksum for outgoing packet for peer %u\n",
>> +				     netdev_name(peer->ovpn->dev), peer->id);
>> +		return false;
>> +	}
>> +
>> +	/* get primary key to be used for encrypting data */
>> +	ks = ovpn_crypto_key_slot_primary(&peer->crypto);
>> +	if (unlikely(!ks))
>> +		return false;
>>   
>>   	/* take a reference to the peer because the crypto code may run async.
>>   	 * ovpn_encrypt_post() will release it upon completion
>> @@ -118,7 +244,8 @@ static bool ovpn_encrypt_one(struct ovpn_peer *peer, struct sk_buff *skb)
> 
> Adding in the few lines that got snipped:
> 
> 	/* take a reference to the peer because the crypto code may run async.
> 	 * ovpn_encrypt_post() will release it upon completion
> 	 */
> 	if (unlikely(!ovpn_peer_hold(peer))) {
> 		DEBUG_NET_WARN_ON_ONCE(1);
> 		return false;
> 	}
> 
> This should never happen, but just in case, we'd want
> ovpn_crypto_key_slot_put() here.

ACK

> 
>>   		return false;
>>   	}
> 

-- 
Antonio Quartulli
OpenVPN Inc.