netdev - Re: [PATCH net-next 0/5] mlxsw: Move Tx header handling to PCI driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87a5bp4m16.fsf@nvidia.com>
Date: Fri, 17 Jan 2025 14:12:27 +0100
From: Petr Machata <petrm@...dia.com>
To: Przemek Kitszel <przemyslaw.kitszel@...el.com>
CC: Petr Machata <petrm@...dia.com>, Richard Cochran
	<richardcochran@...il.com>, Ido Schimmel <idosch@...dia.com>,
	<mlxsw@...dia.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet
	<edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, Andrew Lunn <andrew+netdev@...n.ch>,
	<netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 0/5] mlxsw: Move Tx header handling to PCI driver


Przemek Kitszel <przemyslaw.kitszel@...el.com> writes:

> On 1/16/25 17:38, Petr Machata wrote:
>> Amit Cohen writes:
>> Tx header should be added to all packets transmitted from the CPU to
>> Spectrum ASICs. Historically, handling this header was added as a driver
>> function, as Tx header is different between Spectrum and Switch-X.
>>  From May 2021, there is no support for SwitchX-2 ASIC, and all the relevant
>> code was removed.
>> For now, there is no justification to handle Tx header as part of
>> spectrum.c, we can handle this as part of PCI, in skb_transmit().
>> This change will also be useful when XDP support will be added to mlxsw,
>> as for XDP_TX and XDP_REDIRECT actions, Tx header should be added before
>> transmitting the packet.
>> Patch set overview:
>> Patches #1-#2 add structure to store Tx header info and initialize it
>> Patch #3 moves definitions of Tx header fields to txheader.h
>> Patch #4 moves Tx header handling to PCI driver
>> Patch #5 removes unnecessary attribute
>> Amit Cohen (5):
>>    mlxsw: Add mlxsw_txhdr_info structure
>>    mlxsw: Initialize txhdr_info according to PTP operations
>>    mlxsw: Define Tx header fields in txheader.h
>>    mlxsw: Move Tx header handling to PCI driver
>>    mlxsw: Do not store Tx header length as driver parameter
>>   drivers/net/ethernet/mellanox/mlxsw/core.c    |  21 +-
>>   drivers/net/ethernet/mellanox/mlxsw/core.h    |  13 +-
>>   drivers/net/ethernet/mellanox/mlxsw/i2c.c     |   2 +-
>>   drivers/net/ethernet/mellanox/mlxsw/pci.c     |  44 +++-
>>   .../net/ethernet/mellanox/mlxsw/spectrum.c    | 209 ++++--------------
>>   .../net/ethernet/mellanox/mlxsw/spectrum.h    |  11 +-
>>   .../ethernet/mellanox/mlxsw/spectrum_ptp.c    |  44 +---
>>   .../ethernet/mellanox/mlxsw/spectrum_ptp.h    |  28 ---
>>   .../net/ethernet/mellanox/mlxsw/txheader.h    |  63 ++++++
>>   9 files changed, 176 insertions(+), 259 deletions(-)
>> 
>
> Thank you for cleaning this, nice series!
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>

BTW, it's not just cleanup. When the cover letter says that it "will
also be useful when XDP support will be added" -- we have four more
patchsets in the pipeline that add that. It's not going to land pre
net-next closure, but the next cycle for sure!

Thanks for the review!