netdev - Re: [PATCH net v2] tcp_cubic: fix incorrect HyStart round start detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADVnQymhhNG-W0XAMC-=ptANc8meG08yi2z-C9-+M0yc9-oSMA@mail.gmail.com>
Date: Fri, 17 Jan 2025 09:34:51 -0500
From: Neal Cardwell <ncardwell@...gle.com>
To: Mahdi Arghavani <ma.arghavani@...oo.com>
Cc: Jason Xing <kerneljasonxing@...il.com>, 
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, "edumazet@...gle.com" <edumazet@...gle.com>, 
	"haibo.zhang@...go.ac.nz" <haibo.zhang@...go.ac.nz>, 
	"david.eyers@...go.ac.nz" <david.eyers@...go.ac.nz>, "abbas.arghavani@....se" <abbas.arghavani@....se>
Subject: Re: [PATCH net v2] tcp_cubic: fix incorrect HyStart round start detection

On Fri, Jan 17, 2025 at 3:12 AM Mahdi Arghavani <ma.arghavani@...oo.com> wrote:
>
> Hi,
> >>>+ What is moRTT? Is that ca->curr_rtt? It would be great to share the
> debug patch you used, so we know for certain how to interpret each
> column in the debug output.
>
> Yes. moRTT stands for ca->curr_rtt
> t stands for tp->tcp_mstamp,
> c stands for  tp->snd_cwnd,
> i stands for tcp_packets_in_flight(tp),
> a stands for acked,
> RTT stands for (tp->srtt_us >> 3),
> minRTT stands for  ca->delay_min,
> d  stands for  total delivered,
> l stands for tp->lost,
> tRnd stands for ca->round_start
> Please ignore the rest.
>
> >>>+ Are both HYSTART-DELAY and HYSTART-ACK-TRAIN enabled for both of those tests?
> Yes.
>
> Best Wishes,
> Mahdi Arghavani

Thanks. Can you please send a v3 version of the tcp_cubic.c patch with
the tweaks we have suggested above for the commit message.

thanks,
neal