netdev - Re: [RFC net-next 0/7] Provide an ism layer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bfa431f9-333e-439a-b6b0-8fc16e0f38f1@linux.ibm.com>
Date: Fri, 17 Jan 2025 16:38:21 +0100
From: Alexandra Winter <wintera@...ux.ibm.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: Julian Ruess <julianr@...ux.ibm.com>, dust.li@...ux.alibaba.com,
        Wenjia Zhang <wenjia@...ux.ibm.com>, Jan Karcher <jaka@...ux.ibm.com>,
        Gerd Bayer <gbayer@...ux.ibm.com>, Halil Pasic <pasic@...ux.ibm.com>,
        "D. Wythe" <alibuda@...ux.alibaba.com>,
        Tony Lu <tonylu@...ux.alibaba.com>, Wen Gu <guwen@...ux.alibaba.com>,
        Peter Oberparleiter
 <oberpar@...ux.ibm.com>,
        David Miller <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>,
        Andrew Lunn <andrew+netdev@...n.ch>,
        Niklas Schnelle <schnelle@...ux.ibm.com>,
        Thorsten Winkler <twinkler@...ux.ibm.com>, netdev@...r.kernel.org,
        linux-s390@...r.kernel.org, Heiko Carstens <hca@...ux.ibm.com>,
        Vasily Gorbik <gor@...ux.ibm.com>,
        Alexander Gordeev
 <agordeev@...ux.ibm.com>,
        Christian Borntraeger <borntraeger@...ux.ibm.com>,
        Sven Schnelle <svens@...ux.ibm.com>, Simon Horman <horms@...nel.org>
Subject: Re: [RFC net-next 0/7] Provide an ism layer



On 17.01.25 16:06, Andrew Lunn wrote:
>> With this proposal ism_loopback is just another ism device and SMC-D will
>> handle removal just like ism_client.remove(ism_dev) of other ism devices.
> 
> In Linux terminology, a device is something which has a struct device,
> and a device lives on some sort of bus, even if it is a virtual
> bus. Will ISM devices properly fit into the Linux device driver model?
> 
> 	Andrew
> 

ism_vpci lives on a pci bus (zpci flavor) today. The fact that it is not
backed by a real hardware PCI slot, but emulated by s390 firmware is not
visible to Linux.

In the first proposal, ism_lo lived in on a virtual bus, afaiu. I liked
that. In the current stage 1 implementation that is currently upstream,
it is not visible in sysfs :-(


ism_dev is a bit modeled after net_device. So it is contains a pointer
to a struct device, but it is not the device itself.

I have to admit that the sysfs details are a bit confusing to me,
so I wanted to discuss them first before adding them to the RFC.
But I tried to bring all the prereqs in place.