| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20250117-net-next-mptcp-pm-misc-cleanup-2-v2-0-61d4fe0586e8@kernel.org>
Date: Fri, 17 Jan 2025 19:41:32 +0100
From: "Matthieu Baerts (NGI0)" <matttbe@...nel.org>
To: mptcp@...ts.linux.dev, Mat Martineau <martineau@...nel.org>,
Geliang Tang <geliang@...nel.org>, "David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
"Matthieu Baerts (NGI0)" <matttbe@...nel.org>,
Geliang Tang <geliang@...nel.org>
Subject: [PATCH net-next v2 00/15] mptcp: pm: misc cleanups, part 2
These cleanups lead the way to the unification of the path-manager
interfaces, and allow future extensions. The following patches are not
all linked to each others, but are all related to the path-managers.
- Patch 1: drop unneeded parameter in a function helper.
- Patch 2: clearer NL error message when an NL attribute is missing.
- Patch 3: more precise NL messages by avoiding 'this or that is NOK'.
- Patch 4: improve too vague or missing NL err messages.
- Patch 5: use GENL_REQ_ATTR_CHECK to look for mandatory NL attributes.
- Patch 6: avoid overriding the error message.
- Patch 7: check all mandatory NL attributes with GENL_REQ_ATTR_CHECK.
- Patch 8: use NL_SET_ERR_MSG_ATTR instead of GENL_SET_ERR_MSG
- Patch 9: move doit callbacks used for both PM to pm.c.
- Patch 10: drop another unneeded parameter in a function helper.
- Patch 11: share the ID parsing code for the 'get_addr' callback.
- Patch 12: share sending NL code for the 'get_addr' callback.
- Patch 13: drop yet another unneeded parameter in a function helper.
- Patch 14: pick the usual structure type for the remote address.
- Patch 15: share the local addr parsing code for the 'set_flags' cb.
The behaviour when there are no errors should then not be modified.
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@...nel.org>
---
Changes in v2:
- Patch 11: a variable was no longer assigned, but still used in this
patch (and no longer used in the next one). (Simon)
- I hope it is OK to have this series in parallel of "mptcp: sysctl: add
syn_retrans_before_tcp_fallback", we had 16 patches left in the queue :)
- Link to v1: https://lore.kernel.org/r/20250116-net-next-mptcp-pm-misc-cleanup-2-v1-0-c0b43f18fe06@kernel.org
---
Geliang Tang (9):
mptcp: pm: drop info of userspace_pm_remove_id_zero_address
mptcp: pm: userspace: use GENL_REQ_ATTR_CHECK
mptcp: pm: make three pm wrappers static
mptcp: pm: drop skb parameter of get_addr
mptcp: pm: add id parameter for get_addr
mptcp: pm: reuse sending nlmsg code in get_addr
mptcp: pm: drop skb parameter of set_flags
mptcp: pm: change rem type of set_flags
mptcp: pm: add local parameter for set_flags
Matthieu Baerts (NGI0) (6):
mptcp: pm: userspace: flags: clearer msg if no remote addr
mptcp: pm: more precise error messages
mptcp: pm: improve error messages
mptcp: pm: remove duplicated error messages
mptcp: pm: mark missing address attributes
mptcp: pm: use NL_SET_ERR_MSG_ATTR when possible
net/mptcp/pm.c | 86 +++++++++++++++++--
net/mptcp/pm_netlink.c | 129 ++++++++++-------------------
net/mptcp/pm_userspace.c | 209 +++++++++++++++++++++--------------------------
net/mptcp/protocol.h | 14 ++--
4 files changed, 225 insertions(+), 213 deletions(-)
---
base-commit: 7d2eba0f83a59d360ed1e77ed2778101a6e3c4a1
change-id: 20250116-net-next-mptcp-pm-misc-cleanup-2-b0f50eff8084
Best regards,
--
Matthieu Baerts (NGI0) <matttbe@...nel.org>
Powered by blists - more mailing lists