netdev - Re: [PATCH net-next] net: destroy dev->lock later in free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250117150038.1f009a20@kernel.org>
Date: Fri, 17 Jan 2025 15:00:38 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S . Miller" <davem@...emloft.net>, Paolo Abeni
 <pabeni@...hat.com>, netdev@...r.kernel.org, Simon Horman
 <horms@...nel.org>, Kuniyuki Iwashima <kuniyu@...zon.com>,
 eric.dumazet@...il.com,
 syzbot+85ff1051228a04613a32@...kaller.appspotmail.com
Subject: Re: [PATCH net-next] net: destroy dev->lock later in free_netdev()

On Fri, 17 Jan 2025 22:46:26 +0000 Eric Dumazet wrote:
> syzbot complained that free_netdev() was calling netif_napi_del()
> after dev->lock mutex has been destroyed.
> 
> This fires a warning for CONFIG_DEBUG_MUTEXES=y builds.
> 
> Move mutex_destroy(&dev->lock) near the end of free_netdev().

Reviewed-by: Jakub Kicinski <kuba@...nel.org>