netdev - Re: [PATCH net-next, v5] netlink: support dumping IPv4 multicast addresses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <262b5dce-eca9-429d-92c8-205ce27e02a1@redhat.com>
Date: Fri, 17 Jan 2025 10:53:17 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Yuyang Huang <yuyanghuang@...gle.com>
Cc: "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Simon Horman <horms@...nel.org>, David Ahern <dsahern@...nel.org>,
 netdev@...r.kernel.org, Donald Hunter <donald.hunter@...il.com>,
 Shuah Khan <shuah@...nel.org>, Nikolay Aleksandrov <razor@...ckwall.org>,
 Hangbin Liu <liuhangbin@...il.com>, Daniel Borkmann <daniel@...earbox.net>,
 linux-kselftest@...r.kernel.org, Maciej Żenczykowski
 <maze@...gle.com>, Lorenzo Colitti <lorenzo@...gle.com>
Subject: Re: [PATCH net-next, v5] netlink: support dumping IPv4 multicast
 addresses

On 1/17/25 7:56 AM, Yuyang Huang wrote:
> Hi Paolo
> 
> Thanks for the review feedback, I will adjust them in the patch v6.
> 
>> Why moving the struct definition here? IMHO addrconf.h is better suited
>> and will avoid additional headers dep.
> 
> The `struct inet_fill_args` is moved from devinet.c to igmp.h to make
> it usable in both devinet.c and igmp.c.
> I feel it is incorrect to move `struct inet_fill_args` to addrconf.h
> because that file contains IPv6 specific definition and it also
> contains `struct inet6_fill_args`. After refactoring, I will remove
> the usage of enum addr_type_t type, so we don't need to import
> addrconf.h anymore.

Do you mean that in the next iteration you are going to remove the 'enum
addr_type_t type' filed from struct inet_fill_args? That would be good.

As per the header file, I tend to think that the better choice in this
case would probably be creating a new one.

/P