netdev - Re: [PATCH net-next v2 11/15] mptcp: pm: add id parameter for get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <93cae50d-2ede-46b6-9c4b-e18deefe3295@kernel.org>
Date: Sat, 18 Jan 2025 08:44:24 +0100
From: Matthieu Baerts <matttbe@...nel.org>
To: Geliang Tang <geliang@...nel.org>, mptcp@...ts.linux.dev,
 Mat Martineau <martineau@...nel.org>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Simon Horman <horms@...nel.org>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2 11/15] mptcp: pm: add id parameter for
 get_addr

Hi Geliang,

On 18/01/2025 00:28, Geliang Tang wrote:
> Hi Matt,
> 
> On Fri, 2025-01-17 at 19:41 +0100, Matthieu Baerts (NGI0) wrote:
>> From: Geliang Tang <tanggeliang@...inos.cn>
>>
>> The address id is parsed both in mptcp_pm_nl_get_addr() and
>> mptcp_userspace_pm_get_addr(), this makes the code somewhat
>> repetitive.
>>
>> So this patch adds a new parameter 'id' for all get_addr()
>> interfaces.
>> The address id is only parsed in mptcp_pm_nl_get_addr_doit(), then
>> pass
>> it to both mptcp_pm_nl_get_addr() and mptcp_userspace_pm_get_addr().
>>
>> Signed-off-by: Geliang Tang <tanggeliang@...inos.cn>
>> Reviewed-by: Matthieu Baerts (NGI0) <matttbe@...nel.org>
>> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@...nel.org>
>> ---
>> v2:
>> - Fix 'attr' no longer being set in mptcp_pm_nl_get_addr(), but still
>>   used in this patch (no longer in the next one). (Simon)
> 
> mptcp_userspace_pm_get_addr() needs to be updated too.

Arf, I didn't think about pm_userspace.c :(
I should have definitively squashed patch 11 and 12...

That's OK, I will resend them later, simply moving the line removal from
patch 11 to 12.

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.