netdev - Re: [PATCH net-next v2 0/7] net: ethtool: fixes for HDS threshold

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACKFLi=XNv5wA6J-5mqk1uVmiCLgg4s+4j7Nk9_eDsZYLErGNA@mail.gmail.com>
Date: Sat, 18 Jan 2025 21:14:12 -0800
From: Michael Chan <michael.chan@...adcom.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com, 
	pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org, 
	pavan.chebbi@...adcom.com, ap420073@...il.com
Subject: Re: [PATCH net-next v2 0/7] net: ethtool: fixes for HDS threshold

On Sat, Jan 18, 2025 at 6:05 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> Quick follow up on the HDS threshold work, since the merge window
> is upon us.
>
> Fix the bnxt implementation to apply the settings right away,
> because we update the parameters _after_ configuring HW user
> needed to reconfig the device twice to get the settings to stick.
>
> For this I took the liberty of moving the config to a separate
> struct. This follows my original thinking for the queue API.
> It should also fit more neatly into how many drivers which
> support safe config update operate. Drivers can allocate
> new objects using the "pending" struct.
>
> netdevsim:
>
>   KTAP version 1
>   1..7
>   ok 1 hds.get_hds
>   ok 2 hds.get_hds_thresh
>   ok 3 hds.set_hds_disable
>   ok 4 hds.set_hds_enable
>   ok 5 hds.set_hds_thresh_zero
>   ok 6 hds.set_hds_thresh_max
>   ok 7 hds.set_hds_thresh_gt
>   # Totals: pass:7 fail:0 xfail:0 xpass:0 skip:0 error:0
>
> bnxt:
>
>   KTAP version 1
>   1..7
>   ok 1 hds.get_hds
>   ok 2 hds.get_hds_thresh
>   ok 3 hds.set_hds_disable # SKIP disabling of HDS not supported by the device
>   ok 4 hds.set_hds_enable
>   ok 5 hds.set_hds_thresh_zero
>   ok 6 hds.set_hds_thresh_max
>   ok 7 hds.set_hds_thresh_gt
>   # Totals: pass:6 fail:0 xfail:0 xpass:0 skip:1 error:0
>
> v2:
>  - make sure we always manipulate cfg_pending under rtnl_lock
>  - split patch 2 into 2+3 for ease of review
> v1: https://lore.kernel.org/20250117194815.1514410-1-kuba@kernel.org

For the series,
Reviewed-by: Michael Chan <michael.chan@...adcom.com>

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4209 bytes)