netdev - Re: [PATCH v2 net-next] sysctl net: Remove macro checks for CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL+tcoDVTJ8vA_6wBd6ZDh2pq__fwJ9vzm3Kx5qpMNvaxpObjA@mail.gmail.com>
Date: Sun, 19 Jan 2025 22:34:29 +0800
From: Jason Xing <kerneljasonxing@...il.com>
To: Denis Kirjanov <kirjanov@...il.com>
Cc: netdev@...r.kernel.org, edumazet@...gle.com, davem@...emloft.net, 
	kuba@...nel.org, pabeni@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 net-next] sysctl net: Remove macro checks for CONFIG_SYSCTL

On Sun, Jan 19, 2025 at 9:44 PM Denis Kirjanov <kirjanov@...il.com> wrote:
>
> Since dccp and llc makefiles already check sysctl code
> compilation with xxx-$(CONFIG_SYSCTL)
> we can drop the checks
>
> Signed-off-by: Denis Kirjanov <kirjanov@...il.com>
> ---
> changelog:
> v2: fix the spelling mistake "witn" -> "with"
>
>  net/dccp/sysctl.c        | 4 ----
>  net/llc/sysctl_net_llc.c | 4 ----
>  2 files changed, 8 deletions(-)
>
> diff --git a/net/dccp/sysctl.c b/net/dccp/sysctl.c
> index 3fc474d6e57d..b15845fd6300 100644
> --- a/net/dccp/sysctl.c
> +++ b/net/dccp/sysctl.c
> @@ -11,10 +11,6 @@
>  #include "dccp.h"
>  #include "feat.h"
>
> -#ifndef CONFIG_SYSCTL
> -#error This file should not be compiled without CONFIG_SYSCTL defined
> -#endif
> -

I'd like to know if you're still using DCCP since as far as I know it
will soon be deprecated... If not, the whole code will be removed.

Please take a look at the commit:
commit b144fcaf46d43b1471ad6e4de66235b8cebb3c87
Author: Kuniyuki Iwashima <kuniyu@...zon.com>
Date:   Wed Jun 14 12:47:05 2023 -0700

    dccp: Print deprecation notice.

    DCCP was marked as Orphan in the MAINTAINERS entry 2 years ago in commit
    054c4610bd05 ("MAINTAINERS: dccp: move Gerrit Renker to CREDITS").  It says
    we haven't heard from the maintainer for five years, so DCCP is not well
    maintained for 7 years now.

    Recently DCCP only receives updates for bugs, and major distros disable it
    by default.

    Removing DCCP would allow for better organisation of TCP fields to reduce
    the number of cache lines hit in the fast path.

    Let's add a deprecation notice when DCCP socket is created and schedule its
    removal to 2025.

Thanks,
Jason