netdev - Re: [PATCH net-next v6 3/3] enic: Use the Page Pool API for RX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20250119192754.5203-1-johndale@cisco.com>
Date: Sun, 19 Jan 2025 11:27:54 -0800
From: John Daley <johndale@...co.com>
To: kuba@...nel.org
Cc: andrew+netdev@...n.ch,
	benve@...co.com,
	davem@...emloft.net,
	edumazet@...gle.com,
	johndale@...co.com,
	neescoba@...co.com,
	netdev@...r.kernel.org,
	pabeni@...hat.com,
	satishkh@...co.com
Subject: Re: [PATCH net-next v6 3/3] enic: Use the Page Pool API for RX

On 1/18/25, 5:24 PM, "Jakub Kicinski" kuba@...nel.org wrote:

>On Fri, 17 Jan 2025 00:01:39 -0800 John Daley wrote:
>> @@ -1752,6 +1763,11 @@ static int enic_open(struct net_device *netdev)
>>        }
>>  
>>        for (i = 0; i < enic->rq_count; i++) {
>> +             /* create a page pool for each RQ */
>> +             pp_params.napi = &enic->napi[i];
>> +             pp_params.queue_idx = i;
>> +             enic->rq[i].pool = page_pool_create(&pp_params);
>
>Aren't you missing an error check here?

Yes, v7 coming. Thanks.

>
>>                /* enable rq before updating rq desc */
>>                vnic_rq_enable(&enic->rq[i].vrq);
>>                vnic_rq_fill(&enic->rq[i].vrq, enic_rq_alloc_buf);