netdev - Re: [PATCH net-next v5 1/4] net: wangxun: Add support for PTP clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z4xYmcWH09n3Yg1r@hoboy.vegasvil.org>
Date: Sat, 18 Jan 2025 17:42:49 -0800
From: Richard Cochran <richardcochran@...il.com>
To: Jacob Keller <jacob.e.keller@...el.com>
Cc: Vadim Fedorenko <vadim.fedorenko@...ux.dev>,
	Jiawen Wu <jiawenwu@...stnetic.com>, andrew+netdev@...n.ch,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, linux@...linux.org.uk, horms@...nel.org,
	netdev@...r.kernel.org, mengyuanlou@...-swift.com
Subject: Re: [PATCH net-next v5 1/4] net: wangxun: Add support for PTP clock

On Fri, Jan 17, 2025 at 02:39:14PM -0800, Jacob Keller wrote:
> On 1/17/2025 8:03 AM, Vadim Fedorenko wrote:
> > Well, yes, this case is a special one. Then maybe it's better to adjust
> > Kconfig and Makefile to avoid it?
> 
> Seems simple enough to just have the driver disable the PTP support when
> the kernel doesn't support it, especially if its not a core piece of
> functionality for the device. In cases where the device would be
> functionally useless without PTP support, Kconfig can be used to ensure
> the device driver won't be built without PTP support.

On the one hand, The PTP class layer API is clearly defined, and I
expect device drivers to adhere to it.

On the other, working around a driver's incorrect API usage by
changing the makefile/kconfig is confusing and poor practice.

Thanks,
Richard