netdev - Re: [PATCH net v3] tcp_cubic: fix incorrect HyStart round start detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <173737623226.3511965.17438541188298408042.git-patchwork-notify@kernel.org>
Date: Mon, 20 Jan 2025 12:30:32 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Mahdi Arghavani <ma.arghavani@...oo.com>
Cc: netdev@...r.kernel.org, ncardwell@...gle.com, edumazet@...gle.com,
 haibo.zhang@...go.ac.nz, david.eyers@...go.ac.nz, abbas.arghavani@....se,
 kerneljasonxing@...il.com
Subject: Re: [PATCH net v3] tcp_cubic: fix incorrect HyStart round start detection

Hello:

This patch was applied to netdev/net.git (main)
by David S. Miller <davem@...emloft.net>:

On Fri, 17 Jan 2025 21:37:51 +0000 you wrote:
> I noticed that HyStart incorrectly marks the start of rounds,
> leading to inaccurate measurements of ACK train lengths and
> resetting the `ca->sample_cnt` variable. This inaccuracy can impact
> HyStart's functionality in terminating exponential cwnd growth during
> Slow-Start, potentially degrading TCP performance.
> 
> The issue arises because the changes introduced in commit 4e1fddc98d25
> ("tcp_cubic: fix spurious Hystart ACK train detections for not-cwnd-limited flows")
> moved the caller of the `bictcp_hystart_reset` function inside the `hystart_update` function.
> This modification added an additional condition for triggering the caller,
> requiring that (tcp_snd_cwnd(tp) >= hystart_low_window) must also
> be satisfied before invoking `bictcp_hystart_reset`.
> 
> [...]

Here is the summary with links:
  - [net,v3] tcp_cubic: fix incorrect HyStart round start detection
    https://git.kernel.org/netdev/net/c/25c1a9ca53db

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html