netdev - Re: [GIT PULL] Networking for v6.13-rc7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250120094547.202f4718@kernel.org>
Date: Mon, 20 Jan 2025 09:45:47 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Catalin Marinas <catalin.marinas@....com>
Cc: torvalds@...ux-foundation.org, davem@...emloft.net,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org, pabeni@...hat.com,
 Guo Weikang <guoweikang.kernel@...il.com>, Andrew Morton
 <akpm@...ux-foundation.org>
Subject: Re: [GIT PULL] Networking for v6.13-rc7

On Mon, 20 Jan 2025 14:51:13 +0000 Catalin Marinas wrote:
> > +#include <linux/kmemleak.h>
> >  #include <linux/memblock.h>
> >  #include <linux/printk.h>
> >  #include <linux/numa.h>
> > @@ -23,6 +24,9 @@ void __init alloc_node_data(int nid)
> >  		      nd_size, nid);
> >  	nd = __va(nd_pa);
> >  
> > +	/* needed to track related allocation stored in node_data[] */
> > +	kmemleak_alloc(nd, nd_size, 0, 0);
> > +
> >  	/* report and initialize */
> >  	pr_info("NODE_DATA(%d) allocated [mem %#010Lx-%#010Lx]\n", nid,
> >  		nd_pa, nd_pa + nd_size - 1);  
> 
> Hmm, I don't think this would make any difference as kmemleak does scan
> the memblock allocations as long as they have a correspondent VA in the
> linear map.
> 
> BTW, is NUMA enabled or disabled in your .config?

It's pretty much kernel/configs/debug.config, with virtme-ng, booted
with 4 CPUs. LMK if you can't repro with that, I can provide exact
cmdline.