netdev - Re: [PATCH net-next 3/4] net-sysfs: prevent uncleared queues from being re-added

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250120114400.55fffeda@kernel.org>
Date: Mon, 20 Jan 2025 11:44:00 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Antoine Tenart <atenart@...nel.org>
Cc: davem@...emloft.net, pabeni@...hat.com, edumazet@...gle.com,
 stephen@...workplumber.org, gregkh@...uxfoundation.org,
 netdev@...r.kernel.org
Subject: Re: [PATCH net-next 3/4] net-sysfs: prevent uncleared queues from
 being re-added

On Fri, 17 Jan 2025 11:26:10 +0100 Antoine Tenart wrote:
> +	if (unlikely(kobj->state_initialized))
> +		return -EAGAIN;

we could do some weird stuff here like try to ignore the sysfs 
objects and "resynchronize" them before releasing rtnl.
Way to hacky to do now, but also debugging a transient EAGAIN
will be a major PITA. How about we add a netdev_warn_once()
here to leave a trace of what happened in the logs?