netdev - Re: [PATCH net-next v0] net: mvpp2: Add parser configuration for DSA tags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1ffba10f302ba6c0e3677a9e6c246ef40c415e3d.camel@alliedtelesis.co.nz>
Date: Mon, 20 Jan 2025 23:32:25 +0000
From: Aryan Srivastava <Aryan.Srivastava@...iedtelesis.co.nz>
To: "maxime.chevallier@...tlin.com" <maxime.chevallier@...tlin.com>
CC: "linux@...linux.org.uk" <linux@...linux.org.uk>, "davem@...emloft.net"
	<davem@...emloft.net>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "marcin.s.wojtas@...il.com"
	<marcin.s.wojtas@...il.com>, "edumazet@...gle.com" <edumazet@...gle.com>,
	"kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>
Subject: Re: [PATCH net-next v0] net: mvpp2: Add parser configuration for DSA
 tags

Hi Maxime,

Thank you for your review.
On Thu, 2024-10-10 at 16:17 +0200, Maxime Chevallier wrote:
> ip link set ethX up => triggers a change in the DSA header size
> register
> 
> In that situation, the offset for the VLAN interface ethX.Y's header
> will be incorrect, if the DSA tag type gets updated at .open() time.
> 
> So I think a solution would be to replace the read from the
> MVPP2_MH_REG in the vlan filtering functions with a call your
> newly-introduced mvpp2_get_tag, making sure that we use the correct
> tag
> length for these parser entries as well.
> 
> Thanks,
Yes I agree this can be a potential issue, and I will update the patch
according to your suggestion above.
> 
> Maxime

Thanks, Aryan