netdev - Re: [PATCH] net: mvneta: fix locking in mvneta_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8abc7eed-028e-4fe3-a319-e0936c6bf9e7@oracle.com>
Date: Tue, 21 Jan 2025 06:23:16 +0530
From: Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>
To: Marcin Wojtas <marcin.s.wojtas@...il.com>,
        Andrew Lunn <andrew+netdev@...n.ch>,
        "David S. Miller"
 <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Francois Romieu <romieu@...zoreil.com>,
        Kuniyuki Iwashima
 <kuniyu@...zon.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc: dan.carpenter@...aro.org, kernel-janitors@...r.kernel.org,
        error27@...il.com
Subject: Re: [PATCH] net: mvneta: fix locking in mvneta_cpu_online()

Hi,

On 21/01/25 06:20, Harshit Mogalapalli wrote:
> When port is stopped, unlock before returning
> 
Missed adding a period at the end of sentence. Should I send a V2 ?

Thanks,
Harshit
> Fixes: 413f0271f396 ("net: protect NAPI enablement with netdev_lock()")
> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>
> ---
> This is based on static analysis, only compile tested
> ---
>   drivers/net/ethernet/marvell/mvneta.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c
> index 82f4333fb426..4fe121b9f94b 100644
> --- a/drivers/net/ethernet/marvell/mvneta.c
> +++ b/drivers/net/ethernet/marvell/mvneta.c
> @@ -4432,6 +4432,7 @@ static int mvneta_cpu_online(unsigned int cpu, struct hlist_node *node)
>   	 */
>   	if (pp->is_stopped) {
>   		spin_unlock(&pp->lock);
> +		netdev_unlock(port->napi.dev);
>   		return 0;
>   	}
>   	netif_tx_stop_all_queues(pp->dev);