netdev - Re: [PATCH] net: usb: qmi_wwan: Add error handling for usbnet_get_ethernet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f54876db-8265-4d45-be9f-b18c422251b4@suse.com>
Date: Tue, 21 Jan 2025 10:40:03 +0100
From: Oliver Neukum <oneukum@...e.com>
To: Wentao Liang <vulab@...as.ac.cn>, Jakub Kicinski <kuba@...nel.org>
Cc: Daniele Palmas <dnlplm@...il.com>, Breno Leitao <leitao@...ian.org>,
 netdev@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH] net: usb: qmi_wwan: Add error handling for
 usbnet_get_ethernet_addr

On 20.01.25 18:00, Wentao Liang wrote:
> In qmi_wwan_bind(), usbnet_get_ethernet_addr() is called
> without error handling, risking unnoticed failures and
> inconsistent behavior compared to other parts of the code.

Hi,

unfortunately this makes no difference between a genuine
IO error and the device simply providing no string.
Does the device need to provide a string for the MAC
in order to function?

Frankly, this patch does not look like a good idea,
as it disregards the reasoning expressed in the comment
seen in the code.

	Regards
		Oliver