netdev - Re: [PATCH net-next v6 0/5] net: napi: add CPU affinity to napi->config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2b9ea13d-9b39-451e-8759-148b6716e464@intel.com>
Date: Tue, 21 Jan 2025 07:54:13 -0700
From: Ahmed Zaki <ahmed.zaki@...el.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: <netdev@...r.kernel.org>, <intel-wired-lan@...ts.osuosl.org>,
	<andrew+netdev@...n.ch>, <edumazet@...gle.com>, <horms@...nel.org>,
	<pabeni@...hat.com>, <davem@...emloft.net>, <michael.chan@...adcom.com>,
	<tariqt@...dia.com>, <anthony.l.nguyen@...el.com>,
	<przemyslaw.kitszel@...el.com>, <jdamato@...tly.com>, <shayd@...dia.com>,
	<akpm@...ux-foundation.org>, <shayagr@...zon.com>,
	<kalesh-anakkur.purayil@...adcom.com>
Subject: Re: [PATCH net-next v6 0/5] net: napi: add CPU affinity to
 napi->config



On 2025-01-20 6:03 p.m., Jakub Kicinski wrote:
> On Fri, 17 Jan 2025 17:33:30 -0700 Ahmed Zaki wrote:
>> Drivers usually need to re-apply the user-set IRQ affinity to their IRQs
>> after reset. However, since there can be only one IRQ affinity notifier
>> for each IRQ, registering IRQ notifiers conflicts with the ARFS rmap
>> management in the core (which also registers separate IRQ affinity
>> notifiers).
>>
>> Move the IRQ affinity management to the napi struct. This way we can have
>> a unified IRQ notifier to re-apply the user-set affinity and also manage
>> the ARFS rmaps. Patches 1 and 2 move the ARFS rmap management to CORE.
>> Patch 3 adds the IRQ affinity mask to napi_config and re-applies the mask
>> after reset. Patches 4-6 use the new API for bnxt, ice and idpf drivers.
> 
> Sorry for not-super-in-depth reviews, the patches didn't apply for me :(
> But feels like we are pretty close.

No worries, I will rebase and send when net-next re-opens.

Thanks for the review.