netdev - Re: [PATCH net-next v2 3/3] net: phy: realtek: add hwmon support for temp sensor on RTL822x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a8da8aaf-adba-dbc4-3456-faae86eccd1e@linux-m68k.org>
Date: Tue, 21 Jan 2025 17:10:08 +0100 (CET)
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Heiner Kallweit <hkallweit1@...il.com>
cc: Paolo Abeni <pabeni@...hat.com>, Jakub Kicinski <kuba@...nel.org>, 
    David Miller <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
    Simon Horman <horms@...nel.org>, 
    Russell King - ARM Linux <linux@...linux.org.uk>, 
    Andrew Lunn <andrew@...n.ch>, 
    "netdev@...r.kernel.org" <netdev@...r.kernel.org>, 
    linux-hwmon@...r.kernel.org
Subject: Re: [PATCH net-next v2 3/3] net: phy: realtek: add hwmon support
 for temp sensor on RTL822x

 	Hi Heiner,

CC hwmon

On Sat, 11 Jan 2025, Heiner Kallweit wrote:
> This adds hwmon support for the temperature sensor on RTL822x.
> It's available on the standalone versions of the PHY's, and on
> the integrated PHY's in RTL8125B/RTL8125D/RTL8126.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

Thanks for your patch, which is now commit 33700ca45b7d2e16
("net: phy: realtek: add hwmon support for temp sensor on
RTL822x") in net-next.

> --- a/drivers/net/phy/realtek/Kconfig
> +++ b/drivers/net/phy/realtek/Kconfig
> @@ -3,3 +3,9 @@ config REALTEK_PHY
> 	tristate "Realtek PHYs"
> 	help
> 	  Currently supports RTL821x/RTL822x and fast ethernet PHYs
> +
> +config REALTEK_PHY_HWMON
> +	def_bool REALTEK_PHY && HWMON
> +	depends on !(REALTEK_PHY=y && HWMON=m)
> +	help
> +	  Optional hwmon support for the temperature sensor

So this is optional, but as the symbol is invisible, it cannot be
disabled by the user. Is that intentional?

Gr{oetje,eeting}s,

 						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
 							    -- Linus Torvalds