netdev - Re: [PATCH] net: phy: motorcomm: Fix yt8521 Speed issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5e11c651-ec84-4681-b631-ec771cc8736c@motor-comm.com>
Date: Mon, 20 Jan 2025 19:35:41 -0800
From: "Frank.Sae" <Frank.Sae@...or-comm.com>
To: Xiangqian Zhang <zhangxiangqian@...inos.cn>
Cc: andrew@...n.ch, hkallweit1@...il.com, linux@...linux.org.uk,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: phy: motorcomm: Fix yt8521 Speed issue

On 1/10/25 01:33, Xiangqian Zhang wrote:
> yt8521 is 1000Mb/s after connecting to the network cable, but it is
> still 1000Mb/s after unplugging the network cable.
>
> Signed-off-by: Xiangqian Zhang <zhangxiangqian@...inos.cn>
> ---
>   drivers/net/phy/motorcomm.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/phy/motorcomm.c b/drivers/net/phy/motorcomm.c
> index 0e91f5d1a4fd..e1e33b1236e2 100644
> --- a/drivers/net/phy/motorcomm.c
> +++ b/drivers/net/phy/motorcomm.c
> @@ -1487,6 +1487,7 @@ static int yt8521_read_status(struct phy_device *phydev)
>   		}
>   
>   		phydev->link = 0;
> +		phydev->speed = SPEED_UNKNOWN;
>   	}
>   
>   	return 0;


Dear xiangqian,

you could find the initialization of phydev->speed = SPEED_UNKNOWN;

in yt8521_read_status_paged().

Regards

Frank