netdev - Re: [PATCH] net: davicom: fix UAF in dm9000_drv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z49Af0yc6gbsyIyW@mev-dev.igk.intel.com>
Date: Tue, 21 Jan 2025 07:36:47 +0100
From: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
To: Chenyuan Yang <chenyuan0y@...il.com>
Cc: andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, u.kleine-koenig@...libre.com,
	paul@...pouillou.net, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, zijie98@...il.com
Subject: Re: [PATCH] net: davicom: fix UAF in dm9000_drv_remove

On Mon, Jan 20, 2025 at 04:25:57PM -0600, Chenyuan Yang wrote:
> dm is netdev private data and it cannot be
> used after free_netdev() call. Using adpt after free_netdev()
> can cause UAF bug. Fix it by moving free_netdev() at the end of the
> function.
> 
> This is similar to the issue fixed in commit
> ad297cd2db8953e2202970e9504cab247b6c7cb4 ("net: qcom/emac: fix UAF in emac_remove").
> 
> Fixes: cf9e60aa69ae ("net: davicom: Fix regulator not turned off on driver removal")
> Signed-off-by: Chenyuan Yang <chenyuan0y@...il.com>
> ---
>  drivers/net/ethernet/davicom/dm9000.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/davicom/dm9000.c b/drivers/net/ethernet/davicom/dm9000.c
> index 8735e333034c..b87eaf0c250c 100644
> --- a/drivers/net/ethernet/davicom/dm9000.c
> +++ b/drivers/net/ethernet/davicom/dm9000.c
> @@ -1777,10 +1777,11 @@ static void dm9000_drv_remove(struct platform_device *pdev)
>  
>  	unregister_netdev(ndev);
>  	dm9000_release_board(pdev, dm);
> -	free_netdev(ndev);		/* free device structure */
>  	if (dm->power_supply)
>  		regulator_disable(dm->power_supply);
>  
> +	free_netdev(ndev);		/* free device structure */
> +
>  	dev_dbg(&pdev->dev, "released and freed device\n");
>  }

Reviewed-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>

>  
> -- 
> 2.34.1