netdev - Re: [RFC PATCH 01/10] dt-bindings: net: ti: Adds device tree binding for DUAL-EMAC mode support on PRU-ICSS2 for AM57xx SOCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ef90ecc9-7bb1-4f18-bd14-c5a82f07021b@lunn.ch>
Date: Wed, 22 Jan 2025 14:43:01 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Basharath Hussain Khaja <basharath@...thit.com>
Cc: danishanwar <danishanwar@...com>, rogerq <rogerq@...nel.org>,
	andrew+netdev <andrew+netdev@...n.ch>, davem <davem@...emloft.net>,
	edumazet <edumazet@...gle.com>, kuba <kuba@...nel.org>,
	pabeni <pabeni@...hat.com>, Rob Herring <robh@...nel.org>,
	krzk+dt <krzk+dt@...nel.org>, conor+dt <conor+dt@...nel.org>,
	nm <nm@...com>, ssantosh <ssantosh@...nel.org>,
	tony <tony@...mide.com>, richardcochran <richardcochran@...il.com>,
	parvathi <parvathi@...thit.com>, schnelle <schnelle@...ux.ibm.com>,
	rdunlap <rdunlap@...radead.org>, diogo ivo <diogo.ivo@...mens.com>,
	m-karicheri2 <m-karicheri2@...com>, horms <horms@...nel.org>,
	jacob e keller <jacob.e.keller@...el.com>,
	m-malladi <m-malladi@...com>,
	javier carrasco cruz <javier.carrasco.cruz@...il.com>,
	afd <afd@...com>, s-anna <s-anna@...com>,
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
	netdev <netdev@...r.kernel.org>,
	devicetree <devicetree@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	linux-omap <linux-omap@...r.kernel.org>,
	pratheesh <pratheesh@...com>, prajith <prajith@...com>,
	vigneshr <vigneshr@...com>, praneeth <praneeth@...com>,
	srk <srk@...com>, rogerq <rogerq@...com>,
	krishna <krishna@...thit.com>, pmohan <pmohan@...thit.com>,
	mohan <mohan@...thit.com>
Subject: Re: [RFC PATCH 01/10] dt-bindings: net: ti: Adds device tree binding
 for DUAL-EMAC mode support on PRU-ICSS2 for AM57xx SOCs

On Wed, Jan 22, 2025 at 06:56:14PM +0530, Basharath Hussain Khaja wrote:
> 
> >> +          ti,no-half-duplex:
> >> +            type: boolean
> >> +            description:
> >> +              Disable half duplex operation on ICSSM MII port.
> > 
> > I already asked this in the next patch, but why have this property? Is
> > it because the hardware is broken? Or is this some sort of policy?
> > Policy should not be in DT, DT describes the hardware, not the policy
> > of how you use the hardware.
> > 
> 
> This series of patches enables support for full-duplex only. Support for 
> half-duplex will be added in subsequent revisions. We will clean it up in
> the next version.

So you don't need this property. All you need to do is remove the 1/2
duplex link modes using phy_remove_link_mode() and user space will not
get the option to enable them, not will auto-neg advertise them.

	Andrew