netdev - Re: [PATCH] Documentation/networking: Fix basic node example document ISO 15765-2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <87h65remq7.fsf@trenco.lwn.net>
Date: Tue, 21 Jan 2025 17:06:08 -0700
From: Jonathan Corbet <corbet@....net>
To: Reyders Morales <reyders1@...il.com>, linux-doc@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, valla.francesco@...il.com, Reyders Morales
 <reyders1@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH] Documentation/networking: Fix basic node example
 document ISO 15765-2

[CC += netdev - they may want a resend after the merge window though]

Reyders Morales <reyders1@...il.com> writes:

> In the current struct sockaddr_can tp is member of can_addr.
> tp is not member of struct sockaddr_can.
>
> Signed-off-by: Reyders Morales <reyders1@...il.com>
> ---
>  Documentation/networking/iso15765-2.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/networking/iso15765-2.rst b/Documentation/networking/iso15765-2.rst
> index 0e9d96074178..37ebb2c417cb 100644
> --- a/Documentation/networking/iso15765-2.rst
> +++ b/Documentation/networking/iso15765-2.rst
> @@ -369,8 +369,8 @@ to their default.
>  
>    addr.can_family = AF_CAN;
>    addr.can_ifindex = if_nametoindex("can0");
> -  addr.tp.tx_id = 0x18DA42F1 | CAN_EFF_FLAG;
> -  addr.tp.rx_id = 0x18DAF142 | CAN_EFF_FLAG;
> +  addr.can_addr.tp.tx_id = 0x18DA42F1 | CAN_EFF_FLAG;
> +  addr.can_addr.tp.rx_id = 0x18DAF142 | CAN_EFF_FLAG;
>  
>    ret = bind(s, (struct sockaddr *)&addr, sizeof(addr));
>    if (ret < 0)
> -- 
> 2.43.0