netdev - Re: [PATCH v6 10/10] ARM: dts: aspeed: system1: Disable gpio pull down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7a5bc530-e0f1-4eff-b94c-84d2085014c1@linux.ibm.com>
Date: Wed, 22 Jan 2025 10:09:34 -0600
From: Eddie James <eajames@...ux.ibm.com>
To: Ninad Palsule <ninad@...ux.ibm.com>, minyard@....org, robh@...nel.org,
        krzk+dt@...nel.org, conor+dt@...nel.org, andrew+netdev@...n.ch,
        davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, openipmi-developer@...ts.sourceforge.net,
        netdev@...r.kernel.org, joel@....id.au, andrew@...econstruct.com.au,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-aspeed@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 10/10] ARM: dts: aspeed: system1: Disable gpio pull
 down


On 1/16/25 14:35, Ninad Palsule wrote:
> Disable internal pull down for the following GPIO lines.
> - GPIOL4 - Reset PCH registers in the rtc.
> - GPIOL5 - Reset portition of Intel ME
> - GPIOL6 - FM smi active
> - GPIOL7 - psu all dc power good.


Reviewed-by: Eddie James <eajames@...ux.ibm.com>


>
> Signed-off-by: Ninad Palsule <ninad@...ux.ibm.com>
> ---
>   .../dts/aspeed/aspeed-bmc-ibm-system1.dts     | 28 +++++++++++++++++++
>   1 file changed, 28 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts
> index 9abbad07c751..3cf45a39acbe 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts
> @@ -355,7 +355,35 @@ &uhci {
>   	status = "okay";
>   };
>   
> +&pinctrl {
> +	pinctrl_gpiol4_unbiased: gpiol4 {
> +		pins = "C15";
> +		bias-disable;
> +	};
> +
> +	pinctrl_gpiol5_unbiased: gpiol5 {
> +		pins = "F15";
> +		bias-disable;
> +	};
> +
> +	pinctrl_gpiol6_unbiased: gpiol6 {
> +		pins = "B14";
> +		bias-disable;
> +	};
> +
> +	pinctrl_gpiol7_unbiased: gpiol7 {
> +		pins = "C14";
> +		bias-disable;
> +	};
> +};
> +
>   &gpio0 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_gpiol4_unbiased
> +		&pinctrl_gpiol5_unbiased
> +		&pinctrl_gpiol6_unbiased
> +		&pinctrl_gpiol7_unbiased>;
> +
>   	gpio-line-names =
>   	/*A0-A7*/	"","","","","","","","",
>   	/*B0-B7*/	"","","","","bmc-tpm-reset","","","",