netdev - Re: [PATCH v1 00/21] hwmon: Fix the type of 'config' in struct hwmon_channel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c7cdc9cb-e10f-097e-bd53-bca9b3e2c8d4@huawei.com>
Date: Wed, 22 Jan 2025 11:36:14 +0800
From: "lihuisong (C)" <lihuisong@...wei.com>
To: Guenter Roeck <linux@...ck-us.net>, Armin Wolf <W_Armin@....de>,
	<linux-hwmon@...r.kernel.org>
CC: <linux-kernel@...r.kernel.org>, <linux-media@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>, <arm-scmi@...r.kernel.org>,
	<netdev@...r.kernel.org>, <linux-rtc@...r.kernel.org>,
	<oss-drivers@...igine.com>, <linux-rdma@...r.kernel.org>,
	<platform-driver-x86@...r.kernel.org>, <linuxarm@...wei.com>,
	<jdelvare@...e.com>, <kernel@...davale.org>, <pauk.denis@...il.com>,
	<james@...iv.tech>, <sudeep.holla@....com>, <cristian.marussi@....com>,
	<matt@...ostay.sg>, <mchehab@...nel.org>, <irusskikh@...vell.com>,
	<andrew+netdev@...n.ch>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<kuba@...nel.org>, <pabeni@...hat.com>, <saeedm@...dia.com>,
	<leon@...nel.org>, <tariqt@...dia.com>, <louis.peens@...igine.com>,
	<hkallweit1@...il.com>, <linux@...linux.org.uk>, <kabel@...nel.org>,
	<hdegoede@...hat.com>, <ilpo.jarvinen@...ux.intel.com>,
	<alexandre.belloni@...tlin.com>, <krzk@...nel.org>,
	<jonathan.cameron@...wei.com>, <zhanjie9@...ilicon.com>,
	<zhenglifeng1@...wei.com>, <liuyonglong@...wei.com>
Subject: Re: [PATCH v1 00/21] hwmon: Fix the type of 'config' in struct
 hwmon_channel_info to u64


在 2025/1/22 11:19, Guenter Roeck 写道:
> On 1/21/25 18:52, lihuisong (C) wrote:
>
>>> Those are not hwmon attributes and should not be (or have been) exposed
>>> as sysfs attributes in the first place, but (if really wanted/needed)
>>> through debugfs files. Even _if_ exposed as sysfs attributes they 
>>> should
>>> not have the power1_ prefix (except maybe for the last one).
>> I plan to accept the suggestion Armin proposed that acpi_power_meter 
>> can use the "extra_groups" parameter for these "not generic hwmon 
>> power attributes".
>> Should we drop the power1_ prefix? But this will lead to the change 
>> of these attributes.
>> Do you mean 'power1_is_battery' can be added to hwmon power 
>> attributes in hwmon.h?
>
> No; power1_is_battery is still not a hardware monitoring attribute,
> much less one to standardize. Also, don't change any attribute names.
> They are wrong, but they are the ABI for this driver.
>
Ok, it's clear now.
> .