netdev - Re: [PATCH] ethtool: Fix JSON output for IRQ coalescing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <uaf5yxosya37pt4h4zkygnilk25cidzlj33hbfmbtqete5dywi@jsg4npkqti7c>
Date: Thu, 23 Jan 2025 11:12:53 +0100
From: Michal Kubecek <mkubecek@...e.cz>
To: Michael Edwards <mkedwards@...a.com>
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH] ethtool: Fix JSON output for IRQ coalescing

On Wed, Jan 22, 2025 at 09:40:15AM -0800, Michael Edwards wrote:
> Currently, for a NIC that supports CQE mode settings, the output of
> ethtool --json -c eth0 looks like this:
> 
> [ {
>         "ifname": "eth0",
>         "rx": false,
>         "tx": false,
>         "rx-usecs": 33,
>         "rx-frames": 88,
>         "tx-usecs": 158,
>         "tx-frames": 128,
>         "rx": true,
>         "tx": false
>     } ]
> 
> This diff will change the first rx/tx pair to adaptive-{rx|tx} and
> the second pair to cqe-mode-{rx|tx} to match the keys used to set
> the corresponding settings.
> 
> Fixes: 7e5c1ddbe67d ("pause: add --json support")
> Fixes: ecfb7302cfe6 ("netlink: settings: add netlink support for coalesce cqe mode parameter")
> Signed-off-by: Michael Edwards <mkedwards@...a.com>
> ---

Good catch. I guess I should find some JSON linting tool to run on new
or modified JSON output that would catch issues like this.

Michal