netdev - Re: [PATCH v2] atm/fore200e: Fix possible data race in fore200e

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250123071201.3d38d8f6@kernel.org>
Date: Thu, 23 Jan 2025 07:12:01 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Gui-Dong Han <2045gemini@...il.com>
Cc: 3chas3@...il.com, linux-atm-general@...ts.sourceforge.net,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 baijiaju1990@...il.com, horms@...nel.org, stable@...r.kernel.org
Subject: Re: [PATCH v2] atm/fore200e: Fix possible data race in
 fore200e_open()

On Wed, 22 Jan 2025 02:37:45 +0000 Gui-Dong Han wrote:
> Protect access to fore200e->available_cell_rate with rate_mtx lock to
> prevent potential data race.
> 
> In this case, since the update depends on a prior read, a data race
> could lead to a wrong fore200e.available_cell_rate value.
> 
> The field fore200e.available_cell_rate is generally protected by the lock
> fore200e.rate_mtx when accessed. In all other read and write cases, this
> field is consistently protected by the lock, except for this case and
> during initialization.

Please describe the call paths which interact to cause the race.