netdev - Re: [PATCH net-next v2 5/7] net: ethtool: populate the default HDS params in the core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANn89i+J6g1mD9MEKj7JtWXzMkPRc1SVjeN7Qgd=2i3t9qZ5zg@mail.gmail.com>
Date: Thu, 23 Jan 2025 17:32:52 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, pabeni@...hat.com, 
	andrew+netdev@...n.ch, horms@...nel.org, michael.chan@...adcom.com, 
	pavan.chebbi@...adcom.com, ap420073@...il.com
Subject: Re: [PATCH net-next v2 5/7] net: ethtool: populate the default HDS
 params in the core

On Thu, Jan 23, 2025 at 5:22 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Thu, 23 Jan 2025 17:15:55 +0100 Eric Dumazet wrote:
> > I am unsure how to fix this, should all callers to
> > dev->ethtool_ops->get_ringparam()
> > have to populate  tcp_data_split and hds_thresh from dev->cfg,
> > or would the following fix be enough ?
>
> I think the comparison in nsim_get_ringparam() should look at dev->cfg.
> If the used configuration (dev->cfg) is not set (UNKNOWN), our default
> is ENABLED.

Hmm, I am releasing the syzbot report and let you deal with it then.

Thanks !