netdev - Re: [PATCH net v3] net: phy: c45-tjaxx: add delay between MDIO write and read in soft

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1ae9abac-8fde-4111-9dcb-ad06054db9b3@lunn.ch>
Date: Fri, 24 Jan 2025 15:42:51 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Milos Reljin <milos_reljin@...look.com>
Cc: andrei.botila@....nxp.com, hkallweit1@...il.com, linux@...linux.org.uk,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, milos.reljin@...rk.com
Subject: Re: [PATCH net v3] net: phy: c45-tjaxx: add delay between MDIO write
 and read in soft_reset

On Fri, Jan 24, 2025 at 10:41:02AM +0000, Milos Reljin wrote:
> In application note (AN13663) for TJA1120, on page 30, there's a figure
> with average PHY startup timing values following software reset.
> The time it takes for SMI to become operational after software reset
> ranges roughly from 500 us to 1500 us.
> 
> This commit adds 2000 us delay after MDIO write which triggers software
> reset. Without this delay, soft_reset function returns an error and
> prevents successful PHY init.
> 
> Cc: stable@...r.kernel.org
> Fixes: b050f2f15e04 ("phy: nxp-c45: add driver for tja1103")
> Signed-off-by: Milos Reljin <milos_reljin@...look.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew