netdev - Re: [PATCH net] bonding: Correctly support GSO ESP offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z5MJEShoqJqiNWP6@fedora>
Date: Fri, 24 Jan 2025 03:29:21 +0000
From: Hangbin Liu <liuhangbin@...il.com>
To: Cosmin Ratiu <cratiu@...dia.com>
Cc: netdev@...r.kernel.org, "David S . Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Simon Horman <horms@...nel.org>, Jianbo Liu <jianbol@...dia.com>,
	Boris Pismenny <borisp@...dia.com>,
	Tariq Toukan <tariqt@...dia.com>, linux-kselftest@...r.kernel.org,
	Liang Li <liali@...hat.com>
Subject: Re: [PATCH net] bonding: Correctly support GSO ESP offload

On Thu, Jan 23, 2025 at 05:09:09PM +0200, Cosmin Ratiu wrote:
> The referenced fix is incomplete. It correctly computes
> bond_dev->gso_partial_features across slaves, but unfortunately
> netdev_fix_features discards gso_partial_features from the feature set
> if NETIF_F_GSO_PARTIAL isn't set in bond->features.
> 
> This is visible with ethtool -k bond0 | grep esp:
> tx-esp-segmentation: off [requested on]
> esp-hw-offload: on
> esp-tx-csum-hw-offload: on
> 
> This patch reworks the bonding GSO offload support by:
> - making aggregating gso_partial_features across slaves similar to the
>   other feature sets (this part is a no-op).
> - adding NETIF_F_GSO_PARTIAL to hw_enc_features filtered across slaves.
> - adding NETIF_F_GSO_PARTIAL to features in bond_setup()
> 
> With all of these, 'ethtool -k bond0 | grep esp' now reports:
> tx-esp-segmentation: on
> esp-hw-offload: on
> esp-tx-csum-hw-offload: on
> 
> Fixes: 4861333b4217 ("bonding: add ESP offload features when slaves support")
> Signed-off-by: Cosmin Ratiu <cratiu@...dia.com>
> Change-Id: Iebd2a9d903d3e056e7717e8ca2527a9adf21b2e1

What's Change-Id here? Others looks good to me.

Reviewed-by: Hangbin Liu <liuhangbin@...il.com>