netdev - Re: [PATCH ethtool-next 09/14] qsfp: Add JSON output handling to --module-info in SFF8636 modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250127121606.0c9ace12@kernel.org>
Date: Mon, 27 Jan 2025 12:16:06 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Danielle Ratson <danieller@...dia.com>
Cc: <netdev@...r.kernel.org>, <mkubecek@...e.cz>, <matt@...verse.com.au>,
 <daniel.zahka@...il.com>, <amcohen@...dia.com>,
 <nbu-mlxsw@...hange.nvidia.com>
Subject: Re: [PATCH ethtool-next 09/14] qsfp: Add JSON output handling to
 --module-info in SFF8636 modules

On Sun, 26 Jan 2025 13:56:30 +0200 Danielle Ratson wrote:
> +		open_json_object("extended_identifier");
> +		print_int(PRINT_JSON, "value", "0x%02x",
> +			  map->page_00h[SFF8636_EXT_ID_OFFSET]);

Hm, why hex here?
Priority for JSON output is to make it easy to handle in code,
rather than easy to read. Hex strings need extra manual decoding, no?

BTW thanks for pushing this work forward!