netdev - RE: [Intel-wired-lan] [PATCH iwl-net] idpf: fix handling rsc packet with a single segment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <SJ1PR11MB629722DDBB8E0977B90ED80B9BEC2@SJ1PR11MB6297.namprd11.prod.outlook.com>
Date: Mon, 27 Jan 2025 20:59:46 +0000
From: "Salin, Samuel" <samuel.salin@...el.com>
To: "Samudrala, Sridhar" <sridhar.samudrala@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC: "Samudrala, Sridhar" <sridhar.samudrala@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH iwl-net] idpf: fix handling rsc packet
 with a single segment


> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Samudrala, Sridhar
> Sent: Friday, January 10, 2025 4:29 PM
> To: intel-wired-lan@...ts.osuosl.org; netdev@...r.kernel.org
> Cc: Samudrala, Sridhar <sridhar.samudrala@...el.com>; Kitszel, Przemyslaw
> <przemyslaw.kitszel@...el.com>
> Subject: [Intel-wired-lan] [PATCH iwl-net] idpf: fix handling rsc packet with a
> single segment
> 
> Handle rsc packet with a single segment same as a multi segment rsc packet so
> that CHECKSUM_PARTIAL is set in the
> skb->ip_summed field. The current code is passing CHECKSUM_NONE
> resulting in TCP GRO layer doing checksum in SW and hiding the issue. This will
> fail when using dmabufs as payload buffers as skb frag would be unreadable.
> 
> Fixes: 3a8845af66ed ("idpf: add RX splitq napi poll support")
> Signed-off-by: Sridhar Samudrala <sridhar.samudrala@...el.com>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>

Tested-by: Samuel Salin <Samuel.salin@...el.com>