netdev - Re: [PATCH net] vmxnet3: Fix tx queue race condition with XDP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250127143635.623dc3b0@kernel.org>
Date: Mon, 27 Jan 2025 14:36:35 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Sankararaman Jayaraman <sankararaman.jayaraman@...adcom.com>
Cc: netdev@...r.kernel.org, ronak.doshi@...adcom.com,
 bcm-kernel-feedback-list@...adcom.com, andrew+netdev@...n.ch,
 davem@...emloft.net, u9012063@...il.com, edumazet@...gle.com,
 pabeni@...hat.com, ast@...nel.org, alexandr.lobakin@...el.com,
 alexanderduyck@...com, bpf@...r.kernel.org, daniel@...earbox.net,
 hawk@...nel.org, john.fastabend@...il.com
Subject: Re: [PATCH net] vmxnet3: Fix tx queue race condition with XDP

On Fri, 24 Jan 2025 14:32:11 +0530 Sankararaman Jayaraman wrote:
> + * Copyright (C) 2008-2025, VMware, Inc. All Rights Reserved.

Please don't update copyright dates in a fix.
It increases the size of the patch and risk of a conflict.

> @@ -123,7 +123,9 @@ vmxnet3_xdp_xmit_frame(struct vmxnet3_adapter *adapter,
>  	struct page *page;
>  	u32 buf_size;
>  	u32 dw2;
> +	unsigned long irq_flags;

please order variable declaration lines longest to shortest

> +	spin_lock_irqsave(&tq->tx_lock, irq_flags);

why _irqsave() ?
-- 
pw-bot: cr