netdev - Re: [PATCH net] selftests: net/{lib,openvswitch}: extend CFLAGS to keep options from environment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1e9ec1e3-7a74-4566-ba5b-e937e33336e2@kernel.org>
Date: Mon, 27 Jan 2025 15:50:30 +0100
From: Matthieu Baerts <matttbe@...nel.org>
To: Hangbin Liu <liuhangbin@...il.com>
Cc: Jan Stancek <jstancek@...hat.com>, pshelar@....org, kuba@...nel.org,
 davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
 linux-kselftest@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net] selftests: net/{lib,openvswitch}: extend CFLAGS to
 keep options from environment

Hi Hangbin,

On 26/01/2025 03:03, Hangbin Liu wrote:
> On Thu, Jan 23, 2025 at 01:51:27PM +0100, Matthieu Baerts wrote:
>>> openvswitch/Makefile CFLAGS currently do not appear to be used, but
>>> fix it anyway for the case when new tests are introduced in future.
>>>
>>> Fixes: 1d0dc857b5d8 ("selftests: drv-net: add checksum tests")
>>
>> Note that this commit is only for the Makefile in 'lib', not in
>> 'openvswitch', but I guess there is no need to backport that all along.
>> Maybe the two modifications should be split, but I guess that's fine here.
> 
> Maybe we can also add
> 
> Fixes: 25f16c873fb1 ("selftests: add openvswitch selftest suite")

I don't think it is needed. If it is, probably best to split the patch
in two then.

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.