netdev - Re: [linus:master] [tcp_cubic] 25c1a9ca53: packetdrill.packetdrill/gtests/net/tcp/cubic/cubic-bulk-166k-idle-restart

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADVnQykLL+ZcY0Myg4n0_5PqtOJ9ifxh6nb2VW2txGNDFDF1jg@mail.gmail.com>
Date: Mon, 27 Jan 2025 10:03:05 -0500
From: Neal Cardwell <ncardwell@...gle.com>
To: Jason Xing <kerneljasonxing@...il.com>
Cc: kernel test robot <oliver.sang@...el.com>, Mahdi Arghavani <ma.arghavani@...oo.com>, 
	oe-lkp@...ts.linux.dev, lkp@...el.com, linux-kernel@...r.kernel.org, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Haibo Zhang <haibo.zhang@...go.ac.nz>, David Eyers <david.eyers@...go.ac.nz>, 
	Abbas Arghavani <abbas.arghavani@....se>, netdev@...r.kernel.org
Subject: Re: [linus:master] [tcp_cubic] 25c1a9ca53: packetdrill.packetdrill/gtests/net/tcp/cubic/cubic-bulk-166k-idle-restart_ipv4-mapped-v6.fail

On Mon, Jan 27, 2025 at 5:20 AM Jason Xing <kerneljasonxing@...il.com> wrote:
>
> On Sun, Jan 26, 2025 at 4:49 PM Jason Xing <kerneljasonxing@...il.com> wrote:
> >
> > On Sun, Jan 26, 2025 at 2:30 PM kernel test robot <oliver.sang@...el.com> wrote:
> > >
> > >
> > >
> > > Hello,
> > >
> > > kernel test robot noticed "packetdrill.packetdrill/gtests/net/tcp/cubic/cubic-bulk-166k-idle-restart_ipv4-mapped-v6.fail" on:
> > >
> > > (
> > > in fact, there are other failed cases which can pass on parent:
> > >
> > > 4395a44acb15850e 25c1a9ca53db5780757e7f53e68
> > > ---------------- ---------------------------
> > >        fail:runs  %reproduction    fail:runs
> > >            |             |             |
> > >            :6          100%           6:6     packetdrill.packetdrill/gtests/net/tcp/cubic/cubic-bulk-166k-idle-restart_ipv4-mapped-v6.fail
> > >            :6          100%           6:6     packetdrill.packetdrill/gtests/net/tcp/cubic/cubic-bulk-166k-idle-restart_ipv4.fail
> > >            :6          100%           6:6     packetdrill.packetdrill/gtests/net/tcp/cubic/cubic-bulk-166k-idle-restart_ipv6.fail
> > >            :6          100%           6:6     packetdrill.packetdrill/gtests/net/tcp/cubic/cubic-bulk-166k_ipv4-mapped-v6.fail
> > >            :6          100%           6:6     packetdrill.packetdrill/gtests/net/tcp/cubic/cubic-bulk-166k_ipv4.fail
> > >            :6          100%           6:6     packetdrill.packetdrill/gtests/net/tcp/cubic/cubic-bulk-166k_ipv6.fail
> >
> > Thanks for the report. I remembered that Mahdi once modified/adjusted
> > some of them, please see the link[1].
> >
> > [1]: https://lore.kernel.org/all/223960459.607292.1737102176209@mail.yahoo.com/
> >
> > I think we're supposed to update them altogether?
>
> Should the updated pkt scripts target net or net-next tree, BTW?

Those packetdrill scripts are not in the kernel tree yet in "net" or
"net-next". I suspect they are being pulled from
https://github.com/google/packetdrill ...

I will try to update those packetdrill scripts ASAP, using Mahdi's
updates as a starting point.

It seems that perhaps we should migrate all the Linux packetdrill
scripts to the Linux source tree, so we are not in this confusing
state where some tests are in https://github.com/google/packetdrill
and some are in the Linux source tree...

neal