netdev - Re: [net,v3] tcp: correct handling of extreme memory squeeze

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iLufFGyW0V-RJRhp928HV4+2JF=8BCPQJvTgpagn_OpOQ@mail.gmail.com>
Date: Tue, 28 Jan 2025 17:01:30 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Neal Cardwell <ncardwell@...gle.com>
Cc: jmaloy@...hat.com, netdev@...r.kernel.org, davem@...emloft.net, 
	kuba@...nel.org, passt-dev@...st.top, sbrivio@...hat.com, lvivier@...hat.com, 
	dgibson@...hat.com, memnglong8.dong@...il.com, kerneljasonxing@...il.com, 
	eric.dumazet@...il.com
Subject: Re: [net,v3] tcp: correct handling of extreme memory squeeze

On Tue, Jan 28, 2025 at 4:57 PM Neal Cardwell <ncardwell@...gle.com> wrote:

>
> Yes, thanks for the fix. LGTM as well.
>
> Reviewed-by: Neal Cardwell <ncardwell@...gle.com>
>
> BTW, IMHO it would be nice to have some sort of NET_INC_STATS() of an
> SNMP stat for this case, since we have SNMP stat increases for other
> 0-window cases. That could help debugging performance problems from
> memory pressure and zero windows. But that can be in a separate patch
> for net-next once this fix is in net-next.

This is LINUX_MIB_TCPRCVQDROP  ( TCPRcvQDrop )