netdev - Re: [PATCH net-next v6 07/12] net: homa: create homa_sock.h and homa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXJAmwrKV6bDZgAvDUX2Y0XqhsHROfXPaAYVMsKRNU1XTodTw@mail.gmail.com>
Date: Tue, 28 Jan 2025 09:04:59 -0800
From: John Ousterhout <ouster@...stanford.edu>
To: Eric Dumazet <edumazet@...gle.com>
Cc: Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org, horms@...nel.org, 
	kuba@...nel.org
Subject: Re: [PATCH net-next v6 07/12] net: homa: create homa_sock.h and homa_sock.c

On Tue, Jan 28, 2025 at 7:10 AM Eric Dumazet <edumazet@...gle.com> wrote:
>
> On Tue, Jan 28, 2025 at 1:41 AM John Ousterhout <ouster@...stanford.edu> wrote:
>
> > > The only caller for this function so far is not under RCU lock: you
> > > should see a splat here if you build and run this code with:
> > >
> > > CONFIG_LOCKDEP=y
> > >
> > > (which in turn is highly encouraged)
> >
> > Strange... I have had CONFIG_LOCKDEP enabled for a while now, but for
> > some reason I didn't see a flag for that. In any case, all of the
> > callers to homa_socktab_next now hold the RCU lock (I fixed this
> > during my scan of RCU usage in response to one of your earlier
> > messages for this patch series).
>
> The proper config name is CONFIG_PROVE_LOCKING
>
> CONFIG_PROVE_LOCKING=y
>
> While are it, also add
>
> CONFIG_PROVE_RCU_LIST=y
> CONFIG_RCU_EXPERT=y

I had CONFIG_PROVE_LOCKING already, will add the others now.

-John-