netdev - Re: [PATCH bpf-next v3 01/14] selftests/bpf: helpers: Add append

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e03f6c1d-37c3-4d0b-8e42-1f8980ed379a@linux.dev>
Date: Tue, 28 Jan 2025 14:49:08 -0800
From: Martin KaFai Lau <martin.lau@...ux.dev>
To: "Bastien Curutchet (eBPF Foundation)" <bastien.curutchet@...tlin.com>
Cc: Alexei Starovoitov <ast@...nel.org>,
 Daniel Borkmann <daniel@...earbox.net>, "David S. Miller"
 <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
 Jesper Dangaard Brouer <hawk@...nel.org>,
 John Fastabend <john.fastabend@...il.com>,
 Andrii Nakryiko <andrii@...nel.org>, Eduard Zingerman <eddyz87@...il.com>,
 Song Liu <song@...nel.org>, Yonghong Song <yonghong.song@...ux.dev>,
 KP Singh <kpsingh@...nel.org>, Stanislav Fomichev <sdf@...ichev.me>,
 Hao Luo <haoluo@...gle.com>, Jiri Olsa <jolsa@...nel.org>,
 Mykola Lysenko <mykolal@...com>, Shuah Khan <shuah@...nel.org>,
 Alexis Lothore <alexis.lothore@...tlin.com>,
 Thomas Petazzoni <thomas.petazzoni@...tlin.com>, netdev@...r.kernel.org,
 bpf@...r.kernel.org, linux-kselftest@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH bpf-next v3 01/14] selftests/bpf: helpers: Add
 append_tid()

On 1/28/25 1:57 AM, Bastien Curutchet (eBPF Foundation) wrote:
> Some tests can't be run in parallel because they use same namespace
> names or veth names.
> 
> Create an helper that appends the thread ID to a given string. 8
> characters are used for it (7 digits + '\0')
> 
> Signed-off-by: Bastien Curutchet (eBPF Foundation) <bastien.curutchet@...tlin.com>
> ---
>   tools/testing/selftests/bpf/network_helpers.c | 11 +++++++++++
>   tools/testing/selftests/bpf/network_helpers.h | 10 ++++++++++
>   2 files changed, 21 insertions(+)
> 
> diff --git a/tools/testing/selftests/bpf/network_helpers.c b/tools/testing/selftests/bpf/network_helpers.c
> index 80844a5fb1feef2ff73c2f0293e52495803ab769..d2ff7521aaa696ed04d8f1308394b4c01c1c038b 100644
> --- a/tools/testing/selftests/bpf/network_helpers.c
> +++ b/tools/testing/selftests/bpf/network_helpers.c
> @@ -446,6 +446,17 @@ char *ping_command(int family)
>   	return "ping";
>   }
>   
> +int append_tid(char *str, size_t offset)
nit. offset should always be strlen(str) now. The append_tid will be easier to 
use if the append_tid always does the strlen() itself to figure out the end of 
the str.

It will be useful to replace the "size_t offset" arg with "size_t sz" which 
tells the max size of the "char *str" and the append_tid does a check to ensure 
there is enough space to append the "%07d" tid.

> +{
> +	if (!str)
> +		return -1;
> +
> +	sprintf(&str[offset], "%07d", gettid());
> +	str[offset + 7] = '\0';
> +
> +	return 0;
> +}
> +
>   int remove_netns(const char *name)
>   {
>   	char *cmd;
> diff --git a/tools/testing/selftests/bpf/network_helpers.h b/tools/testing/selftests/bpf/network_helpers.h
> index ebec8a8d6f81e9d079a3b087127a37885c656856..b2451dd00594190e1dcb58498d70dd80c0e7c51c 100644
> --- a/tools/testing/selftests/bpf/network_helpers.h
> +++ b/tools/testing/selftests/bpf/network_helpers.h
> @@ -98,6 +98,16 @@ int send_recv_data(int lfd, int fd, uint32_t total_bytes);
>   int make_netns(const char *name);
>   int remove_netns(const char *name);
>   
> +/**
> + * append_tid() - Append thread ID to the given string.
> + *
> + * /!\ the appended thread ID is 8 characters long
> + *     so the input string must be allocated accordingly
> + *
> + * Returns -1 if input is NULL, 0 otherwise
> + */
> +int append_tid(char *str, size_t offset);
> +
>   static __u16 csum_fold(__u32 csum)
>   {
>   	csum = (csum & 0xffff) + (csum >> 16);
>