netdev - Re: [Patch net v2 2/4] selftests/tc-testing: Add a test case for pfifo_head

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f49814fb-cd69-4c3b-b8d4-c529a99c10e5@mojatatu.com>
Date: Tue, 28 Jan 2025 20:19:54 -0300
From: Pedro Tammela <pctammela@...atatu.com>
To: Cong Wang <xiyou.wangcong@...il.com>, netdev@...r.kernel.org
Cc: jhs@...atatu.com, jiri@...nulli.us, quanglex97@...il.com,
 mincho@...ori.io, Cong Wang <cong.wang@...edance.com>
Subject: Re: [Patch net v2 2/4] selftests/tc-testing: Add a test case for
 pfifo_head_drop qdisc when limit==0

On 26/01/2025 01:12, Cong Wang wrote:
> From: Quang Le <quanglex97@...il.com>
> 
> When limit == 0, pfifo_tail_enqueue() must drop new packet and
> increase dropped packets count of the qdisc.
> 
> All test results:
> 
> 1..16
> ok 1 a519 - Add bfifo qdisc with system default parameters on egress
> ok 2 585c - Add pfifo qdisc with system default parameters on egress
> ok 3 a86e - Add bfifo qdisc with system default parameters on egress with handle of maximum value
> ok 4 9ac8 - Add bfifo qdisc on egress with queue size of 3000 bytes
> ok 5 f4e6 - Add pfifo qdisc on egress with queue size of 3000 packets
> ok 6 b1b1 - Add bfifo qdisc with system default parameters on egress with invalid handle exceeding maximum value
> ok 7 8d5e - Add bfifo qdisc on egress with unsupported argument
> ok 8 7787 - Add pfifo qdisc on egress with unsupported argument
> ok 9 c4b6 - Replace bfifo qdisc on egress with new queue size
> ok 10 3df6 - Replace pfifo qdisc on egress with new queue size
> ok 11 7a67 - Add bfifo qdisc on egress with queue size in invalid format
> ok 12 1298 - Add duplicate bfifo qdisc on egress
> ok 13 45a0 - Delete nonexistent bfifo qdisc
> ok 14 972b - Add prio qdisc on egress with invalid format for handles
> ok 15 4d39 - Delete bfifo qdisc twice
> ok 16 d774 - Check pfifo_head_drop qdisc enqueue behaviour when limit == 0
> 
> Signed-off-by: Quang Le <quanglex97@...il.com>
> Signed-off-by: Cong Wang <cong.wang@...edance.com>
> ---
>   .../tc-testing/tc-tests/qdiscs/fifo.json      | 25 +++++++++++++++++++
>   1 file changed, 25 insertions(+)
> 
> diff --git a/tools/testing/selftests/tc-testing/tc-tests/qdiscs/fifo.json b/tools/testing/selftests/tc-testing/tc-tests/qdiscs/fifo.json
> index ae3d286a32b2..94f6456ab460 100644
> --- a/tools/testing/selftests/tc-testing/tc-tests/qdiscs/fifo.json
> +++ b/tools/testing/selftests/tc-testing/tc-tests/qdiscs/fifo.json
> @@ -313,6 +313,31 @@
>           "matchPattern": "qdisc bfifo 1: root",
>           "matchCount": "0",
>           "teardown": [
> +	]
> +    },
> +    {
> +        "id": "d774",
> +        "name": "Check pfifo_head_drop qdisc enqueue behaviour when limit == 0",
> +        "category": [
> +            "qdisc",
> +            "pfifo_head_drop"
> +        ],
> +        "plugins": {
> +            "requires": "nsPlugin"
> +        },
> +        "setup": [
> +            "$IP link add dev $DUMMY mtu 1279 type dummy || true",

You don't need to manually add or remove a dummy device for tdc anymore.
The nsPlugin is responsible for it.

I ran the suite with both of the tests without the link add/del and it's 
working!

Can you try it?

> +            "$IP addr add 10.10.10.10/24 dev $DUMMY || true",
> +            "$TC qdisc add dev $DUMMY root handle 1: pfifo_head_drop limit 0",
> +            "$IP link set dev $DUMMY up || true"
> +        ],
> +        "cmdUnderTest": "ping -c2 -W0.01 -I $DUMMY 10.10.10.1",
> +        "expExitCode": "1",
> +        "verifyCmd": "$TC -s qdisc show dev $DUMMY",
> +        "matchPattern": "dropped 2",
> +        "matchCount": "1",
> +        "teardown": [
> +            "$IP link del dev $DUMMY"
>           ]
>       }
>   ]