netdev - Re: [PATCH net] ethtool: Fix set RXNFC command with symmetric RSS hash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <173806443227.3766242.421041889613188874.git-patchwork-notify@kernel.org>
Date: Tue, 28 Jan 2025 11:40:32 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Gal Pressman <gal@...dia.com>
Cc: davem@...emloft.net, kuba@...nel.org, horms@...nel.org,
 ecree.xilinx@...il.com, netdev@...r.kernel.org, edumazet@...gle.com,
 pabeni@...hat.com, ahmed.zaki@...el.com, tariqt@...dia.com
Subject: Re: [PATCH net] ethtool: Fix set RXNFC command with symmetric RSS hash

Hello:

This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@...hat.com>:

On Sun, 26 Jan 2025 21:18:45 +0200 you wrote:
> The sanity check that both source and destination are set when symmetric
> RSS hash is requested is only relevant for ETHTOOL_SRXFH (rx-flow-hash),
> it should not be performed on any other commands (e.g.
> ETHTOOL_SRXCLSRLINS/ETHTOOL_SRXCLSRLDEL).
> 
> This resolves accessing uninitialized 'info.data' field, and fixes false
> errors in rule insertion:
>   # ethtool --config-ntuple eth2 flow-type ip4 dst-ip 255.255.255.255 action -1 loc 0
>   rmgr: Cannot insert RX class rule: Invalid argument
>   Cannot insert classification rule
> 
> [...]

Here is the summary with links:
  - [net] ethtool: Fix set RXNFC command with symmetric RSS hash
    https://git.kernel.org/netdev/net/c/4f5a52adeb1a

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html