netdev - RE: [PATCH ethtool-next 09/14] qsfp: Add JSON output handling to --module-info in SFF8636 modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <DM6PR12MB4516969F2EEE1CBF7E5E7A03D8EF2@DM6PR12MB4516.namprd12.prod.outlook.com>
Date: Tue, 28 Jan 2025 13:23:42 +0000
From: Danielle Ratson <danieller@...dia.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "mkubecek@...e.cz"
	<mkubecek@...e.cz>, "matt@...verse.com.au" <matt@...verse.com.au>,
	"daniel.zahka@...il.com" <daniel.zahka@...il.com>, Amit Cohen
	<amcohen@...dia.com>, NBU-mlxsw <NBU-mlxsw@...hange.nvidia.com>
Subject: RE: [PATCH ethtool-next 09/14] qsfp: Add JSON output handling to
 --module-info in SFF8636 modules

> From: Jakub Kicinski <kuba@...nel.org>
> Sent: Monday, 27 January 2025 22:16
> To: Danielle Ratson <danieller@...dia.com>
> Cc: netdev@...r.kernel.org; mkubecek@...e.cz; matt@...verse.com.au;
> daniel.zahka@...il.com; Amit Cohen <amcohen@...dia.com>; NBU-mlxsw
> <nbu-mlxsw@...hange.nvidia.com>
> Subject: Re: [PATCH ethtool-next 09/14] qsfp: Add JSON output handling to --
> module-info in SFF8636 modules
> 
> On Sun, 26 Jan 2025 13:56:30 +0200 Danielle Ratson wrote:
> > +		open_json_object("extended_identifier");
> > +		print_int(PRINT_JSON, "value", "0x%02x",
> > +			  map->page_00h[SFF8636_EXT_ID_OFFSET]);
> 
> Hm, why hex here?
> Priority for JSON output is to make it easy to handle in code, rather than easy
> to read. Hex strings need extra manual decoding, no?

I kept the same convention as in the regular output.
And as agreed in Daniel's design those hex fields remain hex fields and are followed by a description field.

Do you think otherwise?  

>
> BTW thanks for pushing this work forward!

Thanks!