netdev - Re: [TEST] nft-flowtable-sh flaking after pulling first chunk of the merge window

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z5oPNA0IFd7-zBts@calendula>
Date: Wed, 29 Jan 2025 12:21:24 +0100
From: Pablo Neira Ayuso <pablo@...filter.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, fw@...len.de, netfilter-devel@...r.kernel.org
Subject: Re: [TEST] nft-flowtable-sh flaking after pulling first chunk of the
 merge window

Hi Jakub,

On Thu, Jan 23, 2025 at 08:04:44AM -0800, Jakub Kicinski wrote:
> Hi!
> 
> Could be very bad luck but after we fast forwarded net-next yesterday
> we have 3 failures in less than 24h in nft_flowtabl.sh:
> 
> https://netdev.bots.linux.dev/contest.html?test=nft-flowtable-sh
> 
> # FAIL: flow offload for ns1/ns2 with masquerade and pmtu discovery : original counter  2113852 exceeds expected value 2097152, reply counter  60
> https://netdev-3.bots.linux.dev/vmksft-nf/results/960740/11-nft-flowtable-sh/stdout
> 
> # FAIL: flow offload for ns1/ns2 with masquerade and pmtu discovery : original counter  3530493 exceeds expected value 3478585, reply counter  60
> https://netdev-3.bots.linux.dev/vmksft-nf/results/960022/10-nft-flowtable-sh/stdout

this is reporting a flow in forward chain going over the size of the
file, this is a flow that is not follow flowtable path.

> # FAIL: dscp counters do not match, expected dscp3 and dscp0 > 0 but got  1431 , 0 
> https://netdev-3.bots.linux.dev/vmksft-nf/results/960740/11-nft-flowtable-sh-retry/stdout

this is reporting that occasionally a flow does not follow flowtable
path, dscp3 gets bumped from the forward chain.

I can rarely see this last dscp tests FAIL when running this test in a
loop here.

Just a follow up, I am still diagnosing.