netdev - Re: [PATCH net 1/2] net: ipv6: fix dst refleaks in rpl, seg6 and ioam6 lwtunnels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bb85b12c-8c6f-49d7-8192-1ddedffcb2c3@uliege.be>
Date: Thu, 30 Jan 2025 01:16:21 +0100
From: Justin Iurman <justin.iurman@...ege.be>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
 pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org,
 dsahern@...nel.org, Tom Herbert <tom@...bertland.com>
Subject: Re: [PATCH net 1/2] net: ipv6: fix dst refleaks in rpl, seg6 and
 ioam6 lwtunnels

On 1/29/25 21:23, Jakub Kicinski wrote:
> On Wed, 29 Jan 2025 17:17:28 +0100 Justin Iurman wrote:
>>>    net/ipv6/ioam6_iptunnel.c | 5 +++--
>>>    net/ipv6/rpl_iptunnel.c   | 6 ++++--
>>>    net/ipv6/seg6_iptunnel.c  | 6 ++++--
>>>    3 files changed, 11 insertions(+), 6 deletions(-)
>>
>> I think both ila_output() and tipc_udp_xmit() should also be patched
>> accordingly. Other users seem fine.
> 
> TIPC is not a lwt, the cache belongs to a socket not another dst,
> AFAICT.

*sigh* You're right, my bad.

> I think in ILA ilwt->connected will only be set if we re-routed
> the traffic to the real address already? So the dst can't match.
> CC: Tom, full patch:
> https://lore.kernel.org/all/20250129021346.2333089-2-kuba@kernel.org/

Looks like I was in a hurry when I reported this one. On second reading, 
this is also how I understand it.