netdev - Re: [RFC net-next 1/2] netdev-genl: Add an XSK attribute to queues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250130101357.2cd1bbc5@kernel.org>
Date: Thu, 30 Jan 2025 10:13:57 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Joe Damato <jdamato@...tly.com>
Cc: netdev@...r.kernel.org, sridhar.samudrala@...el.com, Donald Hunter
 <donald.hunter@...il.com>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Simon
 Horman <horms@...nel.org>, Andrew Lunn <andrew+netdev@...n.ch>, Xuan Zhuo
 <xuanzhuo@...ux.alibaba.com>, Mina Almasry <almasrymina@...gle.com>, Martin
 Karsten <mkarsten@...terloo.ca>, Amritha Nambiar
 <amritha.nambiar@...el.com>, Stanislav Fomichev <sdf@...ichev.me>, Daniel
 Jurgens <danielj@...dia.com>, open list <linux-kernel@...r.kernel.org>
Subject: Re: [RFC net-next 1/2] netdev-genl: Add an XSK attribute to queues

On Thu, 30 Jan 2025 13:06:47 -0500 Joe Damato wrote:
> On Wed, Jan 29, 2025 at 05:52:24PM -0800, Jakub Kicinski wrote:
> > On Wed, 29 Jan 2025 17:24:24 +0000 Joe Damato wrote:  
> > > Expose a new per-queue attribute, xsk, which indicates that a queue is
> > > being used for AF_XDP. Update the documentation to more explicitly state
> > > which queue types are linked.  
> > 
> > Let's do the same thing we did for io_uring queues? An empty nest:
> > https://lore.kernel.org/all/20250116231704.2402455-6-dw@davidwei.uk/
> > 
> > At the protocol level nest is both smaller and more flexible.
> > It's just 4B with zero length and a "this is a nest" flag.
> > We can add attributes to it as we think of things to express.  
> 
> I got a thing working locally, but just to make sure I'm
> following... you are saying that the attribute will exist (but have
> nothing in it) when the queue has a pool, and when !q->pool the
> attribute will not exist?
> 
> For example:
> 
> [{'id': 0, 'ifindex': 5, 'napi-id': 8266, 'type': 'rx', 'xsk': {}},
>  {'id': 1, 'ifindex': 5, 'napi-id': 8267, 'type': 'rx'},
>  ...
> 
> Is that what you are thinking?

Yup! That's it.

> Completely fine with me as I haven't read enough of the xsk code to
> really have a good sense of what attributes might be helpful to
> expose at this point.