| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <8a4bcb57-ca1a-4fa2-95d6-cff55b41de44@stanley.mountain>
Date: Thu, 30 Jan 2025 08:39:51 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: oe-kbuild@...ts.linux.dev, Michael Chan <michael.chan@...adcom.com>,
davem@...emloft.net
Cc: lkp@...el.com, oe-kbuild-all@...ts.linux.dev, netdev@...r.kernel.org,
edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
andrew+netdev@...n.ch, pavan.chebbi@...adcom.com,
andrew.gospodarek@...adcom.com, michal.swiatkowski@...ux.intel.com,
helgaas@...nel.org, Somnath Kotur <somnath.kotur@...adcom.com>,
Ajit Khaparde <ajit.khaparde@...adcom.com>,
David Wei <dw@...idwei.uk>
Subject: Re: [PATCH net-next v2 09/10] bnxt_en: Extend queue stop/start for
TX rings
Hi Michael,
kernel test robot noticed the following build warnings:
url: https://github.com/intel-lab-lkp/linux/commits/Michael-Chan/bnxt_en-Set-NAPR-1-2-support-when-registering-with-firmware/20250117-032822
base: net-next/main
patch link: https://lore.kernel.org/r/20250116192343.34535-10-michael.chan%40broadcom.com
patch subject: [PATCH net-next v2 09/10] bnxt_en: Extend queue stop/start for TX rings
config: x86_64-randconfig-r071-20250126 (https://download.01.org/0day-ci/archive/20250130/202501300808.5bqgHMA6-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-12) 11.3.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
| Closes: https://lore.kernel.org/r/202501300808.5bqgHMA6-lkp@intel.com/
New smatch warnings:
drivers/net/ethernet/broadcom/bnxt/bnxt.c:15769 bnxt_queue_start() error: uninitialized symbol 'cpr'.
vim +/cpr +15769 drivers/net/ethernet/broadcom/bnxt/bnxt.c
2d694c27d32efc David Wei 2024-06-18 15691 static int bnxt_queue_start(struct net_device *dev, void *qmem, int idx)
2d694c27d32efc David Wei 2024-06-18 15692 {
2d694c27d32efc David Wei 2024-06-18 15693 struct bnxt *bp = netdev_priv(dev);
2d694c27d32efc David Wei 2024-06-18 15694 struct bnxt_rx_ring_info *rxr, *clone;
2d694c27d32efc David Wei 2024-06-18 15695 struct bnxt_cp_ring_info *cpr;
b9d2956e869c78 David Wei 2024-08-07 15696 struct bnxt_vnic_info *vnic;
5d2310614bc883 Somnath Kotur 2025-01-16 15697 struct bnxt_napi *bnapi;
b9d2956e869c78 David Wei 2024-08-07 15698 int i, rc;
2d694c27d32efc David Wei 2024-06-18 15699
2d694c27d32efc David Wei 2024-06-18 15700 rxr = &bp->rx_ring[idx];
2d694c27d32efc David Wei 2024-06-18 15701 clone = qmem;
2d694c27d32efc David Wei 2024-06-18 15702
2d694c27d32efc David Wei 2024-06-18 15703 rxr->rx_prod = clone->rx_prod;
2d694c27d32efc David Wei 2024-06-18 15704 rxr->rx_agg_prod = clone->rx_agg_prod;
2d694c27d32efc David Wei 2024-06-18 15705 rxr->rx_sw_agg_prod = clone->rx_sw_agg_prod;
2d694c27d32efc David Wei 2024-06-18 15706 rxr->rx_next_cons = clone->rx_next_cons;
bd649c5cc95816 David Wei 2024-12-03 15707 rxr->rx_tpa = clone->rx_tpa;
bd649c5cc95816 David Wei 2024-12-03 15708 rxr->rx_tpa_idx_map = clone->rx_tpa_idx_map;
2d694c27d32efc David Wei 2024-06-18 15709 rxr->page_pool = clone->page_pool;
bd649c5cc95816 David Wei 2024-12-03 15710 rxr->head_pool = clone->head_pool;
b537633ce57b29 Taehee Yoo 2024-07-21 15711 rxr->xdp_rxq = clone->xdp_rxq;
2d694c27d32efc David Wei 2024-06-18 15712
2d694c27d32efc David Wei 2024-06-18 15713 bnxt_copy_rx_ring(bp, rxr, clone);
2d694c27d32efc David Wei 2024-06-18 15714
5d2310614bc883 Somnath Kotur 2025-01-16 15715 bnapi = rxr->bnapi;
2d694c27d32efc David Wei 2024-06-18 15716 rc = bnxt_hwrm_rx_ring_alloc(bp, rxr);
2d694c27d32efc David Wei 2024-06-18 15717 if (rc)
5d2310614bc883 Somnath Kotur 2025-01-16 15718 goto err_reset_rx;
cpr isn't initialized
377e78a9e08ce5 Somnath Kotur 2025-01-16 15719
377e78a9e08ce5 Somnath Kotur 2025-01-16 15720 rc = bnxt_hwrm_cp_ring_alloc_p5(bp, rxr->rx_cpr);
2d694c27d32efc David Wei 2024-06-18 15721 if (rc)
5d2310614bc883 Somnath Kotur 2025-01-16 15722 goto err_reset_rx;
2d694c27d32efc David Wei 2024-06-18 15723
377e78a9e08ce5 Somnath Kotur 2025-01-16 15724 rc = bnxt_hwrm_rx_agg_ring_alloc(bp, rxr);
377e78a9e08ce5 Somnath Kotur 2025-01-16 15725 if (rc)
5d2310614bc883 Somnath Kotur 2025-01-16 15726 goto err_reset_rx;
377e78a9e08ce5 Somnath Kotur 2025-01-16 15727
2d694c27d32efc David Wei 2024-06-18 15728 bnxt_db_write(bp, &rxr->rx_db, rxr->rx_prod);
2d694c27d32efc David Wei 2024-06-18 15729 if (bp->flags & BNXT_FLAG_AGG_RINGS)
2d694c27d32efc David Wei 2024-06-18 15730 bnxt_db_write(bp, &rxr->rx_agg_db, rxr->rx_agg_prod);
2d694c27d32efc David Wei 2024-06-18 15731
5d2310614bc883 Somnath Kotur 2025-01-16 15732 cpr = &bnapi->cp_ring;
2d694c27d32efc David Wei 2024-06-18 15733 cpr->sw_stats->rx.rx_resets++;
2d694c27d32efc David Wei 2024-06-18 15734
5d2310614bc883 Somnath Kotur 2025-01-16 15735 if (bp->flags & BNXT_FLAG_SHARED_RINGS) {
5d2310614bc883 Somnath Kotur 2025-01-16 15736 cpr->sw_stats->tx.tx_resets++;
5d2310614bc883 Somnath Kotur 2025-01-16 15737 rc = bnxt_tx_queue_start(bp, idx);
5d2310614bc883 Somnath Kotur 2025-01-16 15738 if (rc) {
5d2310614bc883 Somnath Kotur 2025-01-16 15739 netdev_warn(bp->dev,
5d2310614bc883 Somnath Kotur 2025-01-16 15740 "tx queue restart failed: rc=%d\n", rc);
5d2310614bc883 Somnath Kotur 2025-01-16 15741 bnapi->tx_fault = 1;
5d2310614bc883 Somnath Kotur 2025-01-16 15742 goto err_reset;
5d2310614bc883 Somnath Kotur 2025-01-16 15743 }
5d2310614bc883 Somnath Kotur 2025-01-16 15744 }
5d2310614bc883 Somnath Kotur 2025-01-16 15745
5d2310614bc883 Somnath Kotur 2025-01-16 15746 napi_enable(&bnapi->napi);
5d2310614bc883 Somnath Kotur 2025-01-16 15747 bnxt_db_nq_arm(bp, &cpr->cp_db, cpr->cp_raw_cons);
5d2310614bc883 Somnath Kotur 2025-01-16 15748
b9d2956e869c78 David Wei 2024-08-07 15749 for (i = 0; i <= BNXT_VNIC_NTUPLE; i++) {
b9d2956e869c78 David Wei 2024-08-07 15750 vnic = &bp->vnic_info[i];
5ac066b7b062ee Somnath Kotur 2024-11-22 15751
5ac066b7b062ee Somnath Kotur 2024-11-22 15752 rc = bnxt_hwrm_vnic_set_rss_p5(bp, vnic, true);
5ac066b7b062ee Somnath Kotur 2024-11-22 15753 if (rc) {
5ac066b7b062ee Somnath Kotur 2024-11-22 15754 netdev_err(bp->dev, "hwrm vnic %d set rss failure rc: %d\n",
5ac066b7b062ee Somnath Kotur 2024-11-22 15755 vnic->vnic_id, rc);
5ac066b7b062ee Somnath Kotur 2024-11-22 15756 return rc;
5ac066b7b062ee Somnath Kotur 2024-11-22 15757 }
b9d2956e869c78 David Wei 2024-08-07 15758 vnic->mru = bp->dev->mtu + ETH_HLEN + VLAN_HLEN;
b9d2956e869c78 David Wei 2024-08-07 15759 bnxt_hwrm_vnic_update(bp, vnic,
b9d2956e869c78 David Wei 2024-08-07 15760 VNIC_UPDATE_REQ_ENABLES_MRU_VALID);
b9d2956e869c78 David Wei 2024-08-07 15761 }
b9d2956e869c78 David Wei 2024-08-07 15762
2d694c27d32efc David Wei 2024-06-18 15763 return 0;
2d694c27d32efc David Wei 2024-06-18 15764
5d2310614bc883 Somnath Kotur 2025-01-16 15765 err_reset_rx:
5d2310614bc883 Somnath Kotur 2025-01-16 15766 rxr->bnapi->in_reset = true;
5d2310614bc883 Somnath Kotur 2025-01-16 15767 err_reset:
5d2310614bc883 Somnath Kotur 2025-01-16 15768 napi_enable(&bnapi->napi);
5d2310614bc883 Somnath Kotur 2025-01-16 @15769 bnxt_db_nq_arm(bp, &cpr->cp_db, cpr->cp_raw_cons);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Uninitialized variable
5d2310614bc883 Somnath Kotur 2025-01-16 15770 bnxt_reset_task(bp, true);
2d694c27d32efc David Wei 2024-06-18 15771 return rc;
2d694c27d32efc David Wei 2024-06-18 15772 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists